From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdSM5-0005Uy-C8 for qemu-devel@nongnu.org; Sat, 09 Jun 2012 16:33:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SdSM3-0004Nf-Gh for qemu-devel@nongnu.org; Sat, 09 Jun 2012 16:33:52 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:58791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdSM3-0004NG-7a for qemu-devel@nongnu.org; Sat, 09 Jun 2012 16:33:51 -0400 Received: by obbwd20 with SMTP id wd20so4732398obb.4 for ; Sat, 09 Jun 2012 13:33:48 -0700 (PDT) Sender: fluxion Date: Sat, 9 Jun 2012 15:33:43 -0500 From: Michael Roth Message-ID: <20120609203343.GA10159@illuin> References: <1339169713-31205-1-git-send-email-afaerber@suse.de> <1339169713-31205-2-git-send-email-afaerber@suse.de> <4FD365B7.4080307@redhat.com> <4FD368D2.2060109@suse.de> <4FD36CBA.2070007@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4FD36CBA.2070007@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Anthony Liguori , qemu-devel@nongnu.org On Sat, Jun 09, 2012 at 05:33:14PM +0200, Laszlo Ersek wrote: > On 06/09/12 17:16, Andreas Färber wrote: > > Am 09.06.2012 17:03, schrieb Laszlo Ersek: > >> On 06/08/12 17:35, Andreas Färber wrote: > >>> From: Michael Roth > >>> > >>> This adds visitor interfaces for fixed-width integers types. > >>> Implementing these in visitors is optional, otherwise we fall back to > >>> visit_type_int() (int64_t) with some additional bounds checking to avoid > >>> integer overflows for cases where the value fetched exceeds the bounds > >>> of our target C type. > >> > >>> diff --git a/qapi/qapi-visit-core.h b/qapi/qapi-visit-core.h > >>> index e850746..a19d70c 100644 > >>> --- a/qapi/qapi-visit-core.h > >>> +++ b/qapi/qapi-visit-core.h > >>> @@ -52,6 +52,14 @@ struct Visitor > >>> void (*start_handle)(Visitor *v, void **obj, const char *kind, > >>> const char *name, Error **errp); > >>> void (*end_handle)(Visitor *v, Error **errp); > >>> + void (*type_uint8)(Visitor *v, uint8_t *obj, const char *name, Error **errp); > >>> + void (*type_uint16)(Visitor *v, uint16_t *obj, const char *name, Error **errp); > >>> + void (*type_uint32)(Visitor *v, uint32_t *obj, const char *name, Error **errp); > >>> + void (*type_uint64)(Visitor *v, uint64_t *obj, const char *name, Error **errp); > >>> + void (*type_int8)(Visitor *v, int8_t *obj, const char *name, Error **errp); > >>> + void (*type_int16)(Visitor *v, int16_t *obj, const char *name, Error **errp); > >>> + void (*type_int32)(Visitor *v, int32_t *obj, const char *name, Error **errp); > >>> + void (*type_int64)(Visitor *v, int64_t *obj, const char *name, Error **errp); > >>> }; > >>> > >>> void visit_start_handle(Visitor *v, void **obj, const char *kind, > >>> @@ -69,6 +77,14 @@ void visit_end_optional(Visitor *v, Error **errp); > >>> void visit_type_enum(Visitor *v, int *obj, const char *strings[], > >>> const char *kind, const char *name, Error **errp); > >>> void visit_type_int(Visitor *v, int64_t *obj, const char *name, Error **errp); > >>> +void visit_type_uint8(Visitor *v, uint8_t *obj, const char *name, Error **errp); > >>> +void visit_type_uint16(Visitor *v, uint16_t *obj, const char *name, Error **errp); > >>> +void visit_type_uint32(Visitor *v, uint32_t *obj, const char *name, Error **errp); > >>> +void visit_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp); > >>> +void visit_type_int8(Visitor *v, int8_t *obj, const char *name, Error **errp); > >>> +void visit_type_int16(Visitor *v, int16_t *obj, const char *name, Error **errp); > >>> +void visit_type_int32(Visitor *v, int32_t *obj, const char *name, Error **errp); > >>> +void visit_type_int64(Visitor *v, int64_t *obj, const char *name, Error **errp); > >>> void visit_type_bool(Visitor *v, bool *obj, const char *name, Error **errp); > >>> void visit_type_str(Visitor *v, char **obj, const char *name, Error **errp); > >>> void visit_type_number(Visitor *v, double *obj, const char *name, Error **errp); > >> > >> Shouldn't "scripts/qapi.py" be extended accordingly? (The c_type function.) > > > > What does that affect? > > Is it a blocker for this PULL or an improvement for a follow-up? > > The latter. As long as nothing actually uses these types there's no problem. To clarify: as long as nobody uses these types in a QAPI schema it's fine. The current users don't rely on schema-generated fixed-width types so we're okay as far as the pull. There's an extension to c_type() to support fixed-width types floating around in the QIDL series, but a standalone patch at some point would be warranted as well. > > Laszlo >