From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Peter A. G. Crosthwaite" <peter.crothwaite@petalogix.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build
Date: Sat, 9 Jun 2012 23:23:41 +0200 [thread overview]
Message-ID: <20120609212341.GB5062@zapo> (raw)
In-Reply-To: <4FD36C5B.6020103@suse.de>
On Sat, Jun 09, 2012 at 05:31:39PM +0200, Andreas Färber wrote:
> Am 09.06.2012 17:20, schrieb Edgar E. Iglesias:
> > On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote:
> >> xilinx_ethlite.c uses tswap32(). Have you ever tested this device to work on
> >> microblazeel? I wonder if we could change the device from DEVICE_NATIVE_ENDIAN
> >> to DEVICE_BIG_ENDIAN and in place of tswap32() use a bswap32() conditional on
> >> HOST_WORDS_BIGENDIAN so that it becomes independent of the target, too?
> >
> > I don't think that will work. the swap is needed if the endianness of the host
> > is different from the one of the target...
>
> My thinking was: If we can force the device endianness to a known value
> then only the host endianness (not the target endianness) matters
> because the Memory API will take care of the device endianness.
>
> The question is: Is the device LE for microblazeel or is it always BE?
It can be both LE and BE
>
> > IIRC, the issue is that the device has a built-in RAM mapped so close to
> > the regs that they end up in the same "page". With Avis memory-api maybe it's
> > possible to expose this sub-page area as a memory?
>
> Me and Avi fixed some bugs for subpage areas, it should work in theory
> (for TCG/qtest). Not being aware of a MicroBlaze KVM, if it's a RAM
> region then we should definitely model it as such.
If that's possible, that would get rid of the swaps
Cheers
next prev parent reply other threads:[~2012-06-09 21:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 1:54 [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build Andreas Färber
2012-06-09 1:54 ` [Qemu-devel] [PATCH 1/3] hw/xilinx_*: Share Xilinx devices between ppc and microblaze Andreas Färber
2012-06-09 2:15 ` Peter Crosthwaite
2012-06-09 2:31 ` Andreas Färber
2012-06-09 2:36 ` Peter Crosthwaite
2012-06-09 1:54 ` [Qemu-devel] [PATCH 2/3] qemu-log: Allow usage in libhw Andreas Färber
2012-06-09 1:54 ` [Qemu-devel] [PATCH 3/3] xilinx_axi*: Share devices between microblaze and microblazeel Andreas Färber
2012-06-09 2:16 ` Peter Crosthwaite
2012-06-09 2:06 ` [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build Peter Crosthwaite
2012-06-09 15:20 ` Edgar E. Iglesias
2012-06-09 15:31 ` Andreas Färber
2012-06-09 21:23 ` Edgar E. Iglesias [this message]
2012-06-15 11:13 ` Edgar E. Iglesias
2012-06-15 14:52 ` Andreas Färber
2012-06-16 4:15 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120609212341.GB5062@zapo \
--to=edgar.iglesias@gmail.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crothwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).