From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Sdzx1-000087-FJ
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 04:26:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Sdzwy-0004Lt-HY
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 04:26:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61033)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1Sdzwy-0004Lj-9c
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 04:26:12 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5B8QAeT004706
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 11 Jun 2012 04:26:11 -0400
Date: Mon, 11 Jun 2012 11:26:07 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120611082606.GS20536@garlic.redhat.com>
References: <1339395841-31413-1-git-send-email-alevy@redhat.com>
	<1339395841-31413-2-git-send-email-alevy@redhat.com>
	<4FD5A164.6060403@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FD5A164.6060403@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] qxl: add fb_size_mb and fb_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Jun 11, 2012 at 09:42:28AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > +        if (d->fb_size < fb) {
> > +            d->fb_size = fb;
> > +        }
> > +        if (fb <= d->fb_size) {
> 
> This check doesn't make sense, it will always be true.

My mistake. Will remove the first three lines, so fb_size setting will
be required to get larger modes.

> 
> > +    if (qxl->fb_size_mb != -1 &&
> > +        qxl->fb_size_mb * 1024 * 1024 < qxl->vga.vram_size) {
> > +        qxl->fb_size = qxl->fb_size_mb * 1024 * 1024;
> > +    } else {
> > +        qxl->fb_size = VGA_RAM_SIZE;
> > +    }
> 
> Reminds me that I have some pending work to make vga ram size
> configurable which I should finish and repost ...
> 
> Current state pushed to http://www.kraxel.org/cgit/qemu/log/?h=vga.1
> 
> It probably makes sense to base this on top.

So I can rebase on top and send the patches, with the understanding you
will do any later changes and repost the whole thing.

> 
> > +        DEFINE_PROP_UINT32("fb_size_mb", PCIQXLDevice, fb_size_mb, -1),
> 
> Maybe also rename this to vgamem_mb for consistency with standard vga.

Will change.

> 
> cheers,
>   Gerd
>