From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeBPh-00063z-5x for qemu-devel@nongnu.org; Mon, 11 Jun 2012 16:40:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeBPf-000638-Ca for qemu-devel@nongnu.org; Mon, 11 Jun 2012 16:40:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeBPf-00062Q-3a for qemu-devel@nongnu.org; Mon, 11 Jun 2012 16:40:35 -0400 Date: Mon, 11 Jun 2012 17:05:09 -0300 From: Luiz Capitulino Message-ID: <20120611170509.52e5b473@doriath.home> In-Reply-To: References: <1338787767-3443-1-git-send-email-zwu.kernel@gmail.com> <1338787767-3443-7-git-send-email-zwu.kernel@gmail.com> <4FD59029.5040204@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhi Yong Wu Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, Stefan Hajnoczi , qemu-devel@nongnu.org, Zhi Yong Wu , luowenj@cn.ibm.com, jan.kiszka@siemens.com, Paolo Bonzini On Mon, 11 Jun 2012 22:15:55 +0800 Zhi Yong Wu wrote: > On Mon, Jun 11, 2012 at 2:28 PM, Paolo Bonzini wrot= e: > > Il 09/06/2012 05:04, Zhi Yong Wu ha scritto: > >>>>> This commit looks suspicious because it removes a user-visible qdev > >>>>> property but we're trying to preserve backward compatibility. =A0Th= is > >>>>> command-line will break: > >>>>> > >>>>> x86_64-softmmu/qemu-system-x86_64 -net user,vlan=3D1 -device virtio= -net-pci,vlan=3D1 > >>>>> > >>>>> Instead of dropping the qdev_prop_vlan completely the > >>>>> hw/qdev-properties.c code needs to call net/hub.h external functions > >>>>> to implement equivalent functionality: > >>>>> > >>>>> 1. Setting the vlan=3D property looks up the hub port and assig= ns > >>>>> the NICConf->peer field. > >>>>> 2. Getting the vlan property looks up the hub id (i.e. vlan id) giv= en > >>>>> the peer. =A0If the peer is not a hub port the result is -1. > >>>>> > >>>>> When I wrote this patch I missed the big picture and forgot about > >>>>> backwards compatibility :(. > >>>>> > >> To be honest, i am concerned if anyone uses this syntax. Since the > >> feature will finally be discarded, i suggest that we don't support > >> this now. If someone complains this later, we can fix it. If nobody > >> complains, that is what we hope. > > > > I think you're missing the big picture of this series, which is exactly > > _not_ to discard the VLAN feature, but just to rewrite it in a better w= ay. > Yeah, i know that this series are rewriting VLAN feature in one better wa= y. >=20 > What i mean was that luiz and other some guys think that the -net > syntax should be completely removed. One of the motivations for having the hub feature is to preserve the vlan functionality, in that case we shouldn't break cmd-line backwards compatibi= lity.