From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SeQJE-0007Gh-Fo
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:35:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SeQJ9-0005Ym-Fo
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:34:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SeQJ9-0005Xt-7v
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:34:51 -0400
Date: Tue, 12 Jun 2012 09:35:04 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120612093504.1f7e24f1@doriath.home>
In-Reply-To: <4FD6E7E9.4090408@cn.fujitsu.com>
References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FB9E5CB.2020208@cn.fujitsu.com>
	<20120530162314.1e9e4d3c@doriath.home>
	<4FD6E7E9.4090408@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Gleb Natapov <gleb@redhat.com>, kvm list <kvm@vger.kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Avi Kivity <avi@redhat.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

On Tue, 12 Jun 2012 14:55:37 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:

> >> +static void panicked_perform_action(void)
> >> +{
> >> +    switch(panicked_action) {
> >> +    case PANICKED_REPORT:
> >> +        panicked_mon_event("report");
> >> +        break;
> >> +
> >> +    case PANICKED_PAUSE:
> >> +        panicked_mon_event("pause");
> >> +        vm_stop(RUN_STATE_GUEST_PANICKED);
> >> +        break;
> >> +
> >> +    case PANICKED_QUIT:
> >> +        panicked_mon_event("quit");
> >> +        exit(0);
> >> +        break;
> >> +    }
> > 
> > Having the data argument is not needed/wanted. The mngt app can guess it if it
> > needs to know it, but I think it doesn't want to.
> 
> Libvirt will do something when the kernel is panicked, so it should know the action
> in qemu side.

But the action will be set by libvirt itself, no?