From: Stefan Hajnoczi <stefanha@gmail.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] Makefile: Remove BUILD_DIR from qapi-dir
Date: Tue, 12 Jun 2012 10:49:57 +0100 [thread overview]
Message-ID: <20120612094957.GC29104@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1339225719-5434-1-git-send-email-sw@weilnetz.de>
On Sat, Jun 09, 2012 at 09:08:38AM +0200, Stefan Weil wrote:
> qapi-dir does not need an absolute path. All other build directories
> are relative. When BUILD_DIR is removed, the build output looks better
> (no long lines with absolute paths when everything else uses short
> lines):
>
> GEN qapi-generated/qga-qapi-types.c
> CC qapi-generated/qga-qapi-types.o
> GEN qapi-generated/qga-qapi-visit.c
> CC qapi-generated/qga-qapi-visit.o
> GEN qapi-generated/qga-qmp-marshal.c
> CC qapi-generated/qga-qmp-marshal.o
>
> Using a relative path also avoids potential problems when BUILD_DIR
> includes blanks.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I merged this but have CCed Michael Roth to take a look. qemu.git
contains an earlier commit to explicitly add $(BUILD_DIR):
commit 9b129408589b2ed7bb2cdea03d2aba46a5fd74d4
Author: Michael Roth <mdroth@linux.vnet.ibm.com>
Date: Tue Nov 29 16:47:49 2011 -0600
Makefile: use full path for qapi-generated directory
Generally $(BUILD_DIR) == $(CURDIR), but that isn't necessarilly the
case, so use $(BUILD_DIR)/qapi-generated for generated files to
avoid potentionally sticking generating files in odd places outside
the build's include paths.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Does this rationale still apply? Is it really a good ideal to remove
$(BUILD_DIR)?
Stefan
next prev parent reply other threads:[~2012-06-12 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 7:08 [Qemu-devel] [PATCH 1/2] Makefile: Remove BUILD_DIR from qapi-dir Stefan Weil
2012-06-09 7:08 ` [Qemu-devel] [PATCH 2/2] Makefile: Remove macro qapi-dir Stefan Weil
2012-06-12 9:46 ` [Qemu-devel] [PATCH 1/2] Makefile: Remove BUILD_DIR from qapi-dir Stefan Hajnoczi
2012-06-12 9:49 ` Stefan Hajnoczi [this message]
2012-06-12 14:14 ` Michael Roth
2012-06-13 9:24 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120612094957.GC29104@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).