From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42740)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SelOv-00047Q-KP
	for qemu-devel@nongnu.org; Wed, 13 Jun 2012 07:06:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SelOq-0004co-Rf
	for qemu-devel@nongnu.org; Wed, 13 Jun 2012 07:06:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41749)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SelOq-0004cZ-Jo
	for qemu-devel@nongnu.org; Wed, 13 Jun 2012 07:06:08 -0400
Date: Wed, 13 Jun 2012 14:06:34 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120613110633.GC18001@redhat.com>
References: <1339513523-1699-1-git-send-email-anthony.perard@citrix.com>
	<1339513523-1699-6-git-send-email-anthony.perard@citrix.com>
	<20120612151557.GA10691@redhat.com>
	<alpine.DEB.2.02.1206131154030.14957@kaball.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1206131154030.14957@kaball.uk.xensource.com>
Subject: Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an
	internal function"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, Anthony Liguori <aliguori@us.ibm.com>, QEMU-devel <qemu-devel@nongnu.org>, Xen Devel <xen-devel@lists.xen.org>

On Wed, Jun 13, 2012 at 11:56:34AM +0100, Stefano Stabellini wrote:
> On Tue, 12 Jun 2012, Michael S. Tsirkin wrote:
> > On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote:
> > > This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7.
> > > 
> > > This function is used by a later patch to parse the BDF of the device to
> > > passthrough.
> > > 
> > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> > 
> > You probably want to parse the host address?  You don't want to copy the
> > bugs in pci_parse_devaddr - write your own that has sane semantics
> > for host. E.g. you need to support ARI etc.
> 
> Aside from this minor comment, do you have any objections to this series?

Aside from this, there are minor pci core changes and these are all
fine.
I can't say I looked at the device itself too deeply
but seems mergeable.

> It has been outstanding for 9 months now, and the last few versions have
> been without any major changes.
> Considering that a new QEMU release cycle has just opened, I think that
> now would be the perfect time to get the series in.