From: "Daniel P. Berrange" <berrange@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/3] Add rate limiting of RTC_CHANGE, BALLOON_CHANGE & WATCHDOG events
Date: Wed, 13 Jun 2012 16:04:35 +0100 [thread overview]
Message-ID: <20120613150435.GA364@redhat.com> (raw)
In-Reply-To: <20120530155037.4e5d46df@doriath.home>
On Wed, May 30, 2012 at 03:50:37PM -0300, Luiz Capitulino wrote:
> On Mon, 21 May 2012 17:59:53 +0100
> "Daniel P. Berrange" <berrange@redhat.com> wrote:
> > @@ -4564,6 +4709,11 @@ static void sortcmdlist(void)
> > * End:
> > */
> >
> > +void monitor_global_init(void)
> > +{
>
> It's better to call it monitor_early_init() (or monitor_init_early()).
This was a bit of stupidity on my part. The existing
'monitor_init' function (which is called per monitor
instance), already has a code block where one-time
global initialization is done. So I'm removing this
function in the next patch posting.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2012-06-13 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 16:59 [Qemu-devel] [PATCH v2 0/3] Event notifications for balloon driver Daniel P. Berrange
2012-05-21 16:59 ` [Qemu-devel] [PATCH v2 1/3] Add 'query-events' command to QMP to query async events Daniel P. Berrange
2012-05-22 20:47 ` Luiz Capitulino
2012-05-21 16:59 ` [Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes Daniel P. Berrange
2012-05-21 19:44 ` Amit Shah
2012-05-21 19:50 ` Daniel P. Berrange
2012-05-22 12:50 ` Amit Shah
2012-05-21 16:59 ` [Qemu-devel] [PATCH v2 3/3] Add rate limiting of RTC_CHANGE, BALLOON_CHANGE & WATCHDOG events Daniel P. Berrange
[not found] ` <20120530155037.4e5d46df@doriath.home>
2012-06-08 16:48 ` Daniel P. Berrange
2012-06-11 17:22 ` Luiz Capitulino
2012-06-13 14:53 ` Daniel P. Berrange
2012-06-13 14:57 ` Paolo Bonzini
2012-06-13 15:06 ` Daniel P. Berrange
2012-06-13 15:35 ` Paolo Bonzini
2012-06-13 15:04 ` Daniel P. Berrange [this message]
2012-05-22 20:55 ` [Qemu-devel] [PATCH v2 0/3] Event notifications for balloon driver Luiz Capitulino
2012-05-23 10:35 ` Daniel P. Berrange
2012-05-23 14:16 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613150435.GA364@redhat.com \
--to=berrange@redhat.com \
--cc=amit.shah@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).