From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf5BE-0003VZ-AD for qemu-devel@nongnu.org; Thu, 14 Jun 2012 04:13:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf5B9-0005Z4-GP for qemu-devel@nongnu.org; Thu, 14 Jun 2012 04:13:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf5B9-0005Yt-8T for qemu-devel@nongnu.org; Thu, 14 Jun 2012 04:13:19 -0400 Date: Thu, 14 Jun 2012 11:13:53 +0300 From: "Michael S. Tsirkin" Message-ID: <20120614081352.GE26869@redhat.com> References: <20120614044751.11034.87619.stgit@bling.home> <20120614045205.11034.781.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120614045205.11034.781.stgit@bling.home> Subject: Re: [Qemu-devel] [PATCH v2 6/6] msix: Fix last PCIDevice naming inconsitency List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org On Wed, Jun 13, 2012 at 10:52:06PM -0600, Alex Williamson wrote: > The previous patches fixed almost all the inconsistent names used > for PCIDevice in msix.c, fix the one remaining transgression. > > Signed-off-by: Alex Williamson Except, would be better to first rename parameters and do other mechanical changes, and then apply your diff on top. As it is the patch looks like it rewrites everything while it could be a very small one. > --- > > hw/msix.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/msix.h b/hw/msix.h > index 14b1a2e..1786e27 100644 > --- a/hw/msix.h > +++ b/hw/msix.h > @@ -11,8 +11,7 @@ int msix_init(PCIDevice *dev, unsigned short nentries, > int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries, > uint8_t bar_nr); > > -void msix_write_config(PCIDevice *pci_dev, uint32_t address, > - uint32_t val, int len); > +void msix_write_config(PCIDevice *dev, uint32_t address, uint32_t val, int len); > > void msix_uninit(PCIDevice *dev, MemoryRegion *table_bar, > MemoryRegion *pba_bar);