From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfAuw-0000mE-Tw for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:21:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfAuu-0000af-Qv for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:20:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfAuu-0000aK-J3 for qemu-devel@nongnu.org; Thu, 14 Jun 2012 10:20:56 -0400 Date: Thu, 14 Jun 2012 17:21:29 +0300 From: "Michael S. Tsirkin" Message-ID: <20120614142129.GA17888@redhat.com> References: <20120614044751.11034.87619.stgit@bling.home> <20120614045205.11034.781.stgit@bling.home> <20120614081352.GE26869@redhat.com> <1339683490.24818.24.camel@ul30vt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1339683490.24818.24.camel@ul30vt> Subject: Re: [Qemu-devel] [PATCH v2 6/6] msix: Fix last PCIDevice naming inconsitency List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org On Thu, Jun 14, 2012 at 08:18:10AM -0600, Alex Williamson wrote: > On Thu, 2012-06-14 at 11:13 +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 10:52:06PM -0600, Alex Williamson wrote: > > > The previous patches fixed almost all the inconsistent names used > > > for PCIDevice in msix.c, fix the one remaining transgression. > > > > > > Signed-off-by: Alex Williamson > > > > Except, would be better to first rename parameters and > > do other mechanical changes, and then apply your diff > > on top. > > > > As it is the patch looks like it rewrites everything while > > it could be a very small one. > > You're welcome for trying to add consistency, sorry I pointed it out. No problem with this patch itself though. > > > --- > > > > > > hw/msix.h | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/hw/msix.h b/hw/msix.h > > > index 14b1a2e..1786e27 100644 > > > --- a/hw/msix.h > > > +++ b/hw/msix.h > > > @@ -11,8 +11,7 @@ int msix_init(PCIDevice *dev, unsigned short nentries, > > > int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries, > > > uint8_t bar_nr); > > > > > > -void msix_write_config(PCIDevice *pci_dev, uint32_t address, > > > - uint32_t val, int len); > > > +void msix_write_config(PCIDevice *dev, uint32_t address, uint32_t val, int len); > > > > > > void msix_uninit(PCIDevice *dev, MemoryRegion *table_bar, > > > MemoryRegion *pba_bar); > >