qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: mst@redhat.com
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3 4/8] msix: Move msix_mmio_read
Date: Thu, 14 Jun 2012 12:16:19 -0600	[thread overview]
Message-ID: <20120614181618.23440.82571.stgit@bling.home> (raw)
In-Reply-To: <20120614181104.23440.62204.stgit@bling.home>

What's this doing so far from msix_mmio_ops?

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 hw/msix.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/hw/msix.c b/hw/msix.c
index bafea94..50885ac 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -86,16 +86,6 @@ static int msix_add_config(struct PCIDevice *pdev, unsigned short nentries,
     return 0;
 }
 
-static uint64_t msix_mmio_read(void *opaque, target_phys_addr_t addr,
-                               unsigned size)
-{
-    PCIDevice *dev = opaque;
-    unsigned int offset = addr & (MSIX_PAGE_SIZE - 1) & ~0x3;
-    void *page = dev->msix_table_page;
-
-    return pci_get_long(page + offset);
-}
-
 static uint8_t msix_pending_mask(int vector)
 {
     return 1 << (vector % 8);
@@ -203,6 +193,16 @@ void msix_write_config(PCIDevice *dev, uint32_t addr,
     }
 }
 
+static uint64_t msix_mmio_read(void *opaque, target_phys_addr_t addr,
+                               unsigned size)
+{
+    PCIDevice *dev = opaque;
+    unsigned int offset = addr & (MSIX_PAGE_SIZE - 1) & ~0x3;
+    void *page = dev->msix_table_page;
+
+    return pci_get_long(page + offset);
+}
+
 static void msix_mmio_write(void *opaque, target_phys_addr_t addr,
                             uint64_t val, unsigned size)
 {

  parent reply	other threads:[~2012-06-14 18:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 18:15 [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location Alex Williamson
2012-06-14 18:15 ` [Qemu-devel] [PATCH v3 1/8] msix: Add simple BAR allocation MSIX setup functions Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 2/8] ivshmem: Convert to msix_init_exclusive_bar() interface Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 3/8] virtio: " Alex Williamson
2012-06-14 18:16 ` Alex Williamson [this message]
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 6/8] msix: Split PBA into it's own MemoryRegion Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 7/8] msix: Allow full specification of MSIX layout Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 8/8] msix: Switch msix_uninit to return void Alex Williamson
2012-06-14 21:31 ` [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location Michael S. Tsirkin
2012-06-18  7:06   ` Jan Kiszka
2012-06-18  7:19     ` Michael S. Tsirkin
2012-06-18  9:23       ` Jan Kiszka
2012-06-18  9:57         ` Michael S. Tsirkin
2012-06-18 10:36           ` Jan Kiszka
2012-06-18 22:37             ` Jan Kiszka
2012-06-18 22:40               ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120614181618.23440.82571.stgit@bling.home \
    --to=alex.williamson@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).