From: Alex Williamson <alex.williamson@redhat.com>
To: mst@redhat.com
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item
Date: Thu, 14 Jun 2012 12:16:28 -0600 [thread overview]
Message-ID: <20120614181627.23440.46436.stgit@bling.home> (raw)
In-Reply-To: <20120614181104.23440.62204.stgit@bling.home>
MSIX, like PCI, is little endian. Specifying native is wrong here,
but we need to check the rest of the file to determine if it's
as simple as flipping this macro.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/msix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/msix.c b/hw/msix.c
index 50885ac..87d316a 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque, target_phys_addr_t addr,
static const MemoryRegionOps msix_mmio_ops = {
.read = msix_mmio_read,
.write = msix_mmio_write,
+ /* TODO: MSIX should be LITTLE_ENDIAN. */
.endianness = DEVICE_NATIVE_ENDIAN,
.valid = {
.min_access_size = 4,
next prev parent reply other threads:[~2012-06-14 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 18:15 [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location Alex Williamson
2012-06-14 18:15 ` [Qemu-devel] [PATCH v3 1/8] msix: Add simple BAR allocation MSIX setup functions Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 2/8] ivshmem: Convert to msix_init_exclusive_bar() interface Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 3/8] virtio: " Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 4/8] msix: Move msix_mmio_read Alex Williamson
2012-06-14 18:16 ` Alex Williamson [this message]
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 6/8] msix: Split PBA into it's own MemoryRegion Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 7/8] msix: Allow full specification of MSIX layout Alex Williamson
2012-06-14 18:16 ` [Qemu-devel] [PATCH v3 8/8] msix: Switch msix_uninit to return void Alex Williamson
2012-06-14 21:31 ` [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location Michael S. Tsirkin
2012-06-18 7:06 ` Jan Kiszka
2012-06-18 7:19 ` Michael S. Tsirkin
2012-06-18 9:23 ` Jan Kiszka
2012-06-18 9:57 ` Michael S. Tsirkin
2012-06-18 10:36 ` Jan Kiszka
2012-06-18 22:37 ` Jan Kiszka
2012-06-18 22:40 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614181627.23440.46436.stgit@bling.home \
--to=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).