From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfUTT-0002Ie-5P for qemu-devel@nongnu.org; Fri, 15 Jun 2012 07:14:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfUTM-0004c7-LQ for qemu-devel@nongnu.org; Fri, 15 Jun 2012 07:13:54 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:60840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfUTM-0004bv-Bi for qemu-devel@nongnu.org; Fri, 15 Jun 2012 07:13:48 -0400 Received: by lbok6 with SMTP id k6so3064746lbo.4 for ; Fri, 15 Jun 2012 04:13:45 -0700 (PDT) Date: Fri, 15 Jun 2012 13:13:39 +0200 From: "Edgar E. Iglesias" Message-ID: <20120615111339.GA7617@edde.se.axis.com> References: <1339206871-4706-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1339206871-4706-1-git-send-email-afaerber@suse.de> Subject: Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Blue Swirl , Paolo Bonzini , "Peter A. G. Crosthwaite" , qemu-devel@nongnu.org, Alexander Graf On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote: > Hello Edgar and Peter, > > With the Makefile refactoring applied now, here's the Makefile improvements > for MicroBlaze I mentioned. > > All Xilinx devices that are used for more than one softmmu are compiled once > in libhw32. Actually some also in libhw64 due to ppc440 being compiled into > ppc64, but we can fix that in a second step via Alex' ppc-next, we're already > down from thrice to twice. > > The middle patch is extracted from Blue's logging refactoring. > > Please test and apply. Your s3adp1800 and virtel_ml507 test images complain > both with and without patches about not finding "eth0". Selftest completes ok > except for not finding /usr/bin/sha1test on ppc440. > > xilinx_ethlite.c uses tswap32(). Have you ever tested this device to work on > microblazeel? I wonder if we could change the device from DEVICE_NATIVE_ENDIAN > to DEVICE_BIG_ENDIAN and in place of tswap32() use a bswap32() conditional on > HOST_WORDS_BIGENDIAN so that it becomes independent of the target, too? > > Instead of adding random devices to hw/microblaze/Makefile.objs in new series, > they should be added to hw/Makefile.objs with appropriate CONFIG_* options set > in default-configs/microblaze[el]-softmmu.mak as demonstrated here, easy to do > and also ensures that the appropriate poisoning is applied. Applied the series, thanks Andreas. > > Regards, > Andreas > > Cc: Edgar E. Iglesias > Cc: Peter A. G. Crosthwaite > Cc: Alexander Graf > Cc: Blue Swirl > > Andreas Färber (3): > hw/xilinx_*: Share Xilinx devices between ppc and microblaze > qemu-log: Allow usage in libhw > xilinx_axi*: Share devices between microblaze and microblazeel > > default-configs/microblaze-softmmu.mak | 2 ++ > default-configs/microblazeel-softmmu.mak | 2 ++ > default-configs/ppc-softmmu.mak | 1 + > default-configs/ppc64-softmmu.mak | 1 + > default-configs/ppcemb-softmmu.mak | 1 + > hw/Makefile.objs | 7 +++++++ > hw/microblaze/Makefile.objs | 5 ----- > hw/ppc/Makefile.objs | 3 --- > qemu-log.h | 2 ++ > 9 files changed, 16 insertions(+), 8 deletions(-) > > -- > 1.7.7 >