From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZMB-0002pJ-OA for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:26:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfZM6-0002m6-SS for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:26:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZM6-0002lV-Jx for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:26:38 -0400 Date: Fri, 15 Jun 2012 13:26:05 -0300 From: Luiz Capitulino Message-ID: <20120615132605.2f438780@doriath.home> In-Reply-To: <4FDB54BF.8050703@linux.vnet.ibm.com> References: <1339689305-27031-1-git-send-email-coreyb@linux.vnet.ibm.com> <1339689305-27031-3-git-send-email-coreyb@linux.vnet.ibm.com> <20120615113248.7eea2ead@doriath.home> <4FDB4EF0.2020500@linux.vnet.ibm.com> <20120615121425.6f57b464@doriath.home> <4FDB54BF.8050703@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, eblake@redhat.com On Fri, 15 Jun 2012 11:29:03 -0400 Corey Bryant wrote: > >> I'm not clear on what the problem is with returning the same error class > >> for two different errors. Could you explain? I don't have a problem > >> changing it if it's an issue. > > > > Because an mngt app/user won't know if what has happened was that the fd name > > is invalid or if the fd name already exists. > > > > I agree, it makes sense so the management app can program based on the > error class. It just seems like the error classes in general should be > able to be used multiple times if it fits, especially if we're trying to > avoid having too specific errors. > > Maybe (in the future) something like a sub-class could be used? In other > words to allow using the same error class with unique sub-classes. There's a discussion going on which is more or less the same topic: http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg02243.html