From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Shrinidhi Joshi <spjoshi31@gmail.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Jeff Cody <jcody@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] [v1 Patch 0/10]Qemu: Dynamic host pagecache change and image file reopen
Date: Sat, 16 Jun 2012 02:16:48 +0530 [thread overview]
Message-ID: <20120615204648.9853.1225.sendpatchset@skannery.in.ibm.com> (raw)
For changing host pagecache setting of a running VM, it is
important to have a safe way of reopening its image file.
Following patchset introduces:
* a generic way to reopen image files safely.
In this approach, before reopening an image, for each
block driver, its state will be stashed. Incase preparation,
(bdrv_reopen_prepare) for reopening returns success, the stashed
state will be cleared (bdrv_reopen_commit) and reopened state will
be used further. Incase preparation of reopening returns failure,
the state of the driver will be rolled back (bdrv_reopen_abort)
to the stashed state. This approach is implemented for raw-posix,
raw-win32, vmdk, qcow, qcow2 and qed block drivers.
* qmp and hmp command 'block_set_hostcache' using which host
pagecache setting for a block device can be changed
when the VM is running.
* BDRVReopenState, a generic structure which can be
extended by each of the block drivers to reopen
respective image files.
ToDo:
* Currently driver state is stashed by field-by-field copy.
Optimise this by stashing only the required fields.
* Find out other drivers needing bdrv_reopen implementation.
* Do some more extensive testing, especially with drivers like
floppy, cdrom etc..
Earlier discussions on RFC for dynamic change of host pagecache can be
found at: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg04139.html
New block command added:
"block_set_hostcache"
-- Sets hostcache parameter for block device while guest is running.
Usage:
block_set_hostcache <device> <option>
<device> = block device
<option> = on/off
qemu/block.c | 127 ++++++++++++++++++++++++++++++++--
qemu/block.h | 5 +
qemu/block/qcow.c | 108 +++++++++++++++++++++++++++++
qemu/block/qcow2.c | 177 +++++++++++++++++++++++++++++++++++++++++++++++++
qemu/block/qed.c | 103 ++++++++++++++++++++++++++++
qemu/block/raw-posix.c | 123 ++++++++++++++++++++++++++++++++++
qemu/block/raw-win32.c | 96 ++++++++++++++++++++++++++
qemu/block/raw.c | 20 +++++
qemu/block/vmdk.c | 103 ++++++++++++++++++++++++++++
qemu/block_int.h | 11 +++
qemu/blockdev.c | 24 ++++++
qemu/hmp-commands.hx | 16 ++++
qemu/hmp.c | 11 ++
qemu/hmp.h | 1
qemu/qapi-schema.json | 20 ++++-
qemu/qemu-common.h | 1
qemu/qerror.c | 8 ++
qemu/qerror.h | 6 +
qemu/qmp-commands.hx | 24 ++++++
19 files changed, 971 insertions(+), 13 deletions(-)
next reply other threads:[~2012-06-15 20:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 20:46 Supriya Kannery [this message]
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting Supriya Kannery
2012-06-15 21:07 ` Eric Blake
2012-07-09 14:43 ` Kevin Wolf
2012-07-11 14:03 ` Luiz Capitulino
2012-07-29 6:21 ` Supriya Kannery
2012-07-05 16:38 ` Jeff Cody
2012-07-29 6:54 ` Supriya Kannery
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 2/10]Qemu: Error classes for hostcache setting and data sync failures Supriya Kannery
2012-07-09 14:47 ` Kevin Wolf
2012-07-29 6:58 ` Supriya Kannery
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change Supriya Kannery
2012-06-15 21:56 ` Eric Blake
2012-07-29 7:33 ` Supriya Kannery
2012-06-20 18:18 ` Jeff Cody
2012-07-04 5:10 ` Shrinidhi Joshi
2012-07-04 6:30 ` Kevin Wolf
2012-07-09 14:52 ` Kevin Wolf
2012-07-11 14:16 ` Luiz Capitulino
2012-07-29 7:56 ` Supriya Kannery
2012-06-15 20:47 ` [Qemu-devel] [v1 Patch 4/10]Qemu: Framework for reopening image files safely Supriya Kannery
2012-06-15 22:02 ` Eric Blake
2012-07-09 15:06 ` Kevin Wolf
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 5/10]Qemu: raw-posix image file reopen Supriya Kannery
2012-06-15 22:11 ` Eric Blake
2012-07-04 5:15 ` Shrinidhi Joshi
2012-07-04 11:32 ` Eric Blake
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 6/10]Qemu: raw-win32 " Supriya Kannery
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 7/10]Qemu: vmdk " Supriya Kannery
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 8/10]Qemu: qcow2 " Supriya Kannery
2012-06-15 20:48 ` [Qemu-devel] [v1 Patch 9/10]Qemu: qcow " Supriya Kannery
2012-06-15 20:49 ` [Qemu-devel] [v1 Patch 10/10]Qemu: qed " Supriya Kannery
2012-07-09 17:51 ` [Qemu-devel] [v1 Patch 0/10]Qemu: Dynamic host pagecache change and " Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615204648.9853.1225.sendpatchset@skannery.in.ibm.com \
--to=supriyak@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spjoshi31@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).