From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SgAvq-0001pP-L4
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 04:34:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SgAvo-0004f4-VW
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 04:34:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SgAvo-0004e0-No
	for qemu-devel@nongnu.org; Sun, 17 Jun 2012 04:34:00 -0400
Date: Sun, 17 Jun 2012 11:34:27 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120617083427.GB28089@redhat.com>
References: <36AF4B62444F4B4FB04EDD1FDAE1CF1D4889875E@G4W3209.americas.hpqcorp.net>
	<20120612082641.GC12356@redhat.com>
	<36AF4B62444F4B4FB04EDD1FDAE1CF1D48899822@G4W3209.americas.hpqcorp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <36AF4B62444F4B4FB04EDD1FDAE1CF1D48899822@G4W3209.americas.hpqcorp.net>
Subject: Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when
 adding PCI passthru device.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Ma, Stephen B." <stephen.ma@hp.com>, Anthony Liguori <anthony@codemonkey.ws>
Cc: "'qemu-devel@nongnu.org'" <qemu-devel@nongnu.org>

On Sun, Jun 17, 2012 at 06:26:33AM +0000, Ma, Stephen B. wrote:
> 
> Michael,
> 
> Thanks for the review.  I added the unparent to the qdev_free.
> 
> 
> ---
>  hw/qdev.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/qdev.c b/hw/qdev.c
> index d2dc28b..ed1328d 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -264,6 +264,7 @@ void qdev_init_nofail(DeviceState *dev)
>  /* Unlink device from bus and free the structure.  */
>  void qdev_free(DeviceState *dev)
>  {
> +    object_unparent(OBJECT(dev));
>      object_delete(OBJECT(dev));
>  }
> 
> --
> 1.7.1

Anthony, any feedback?

-- 
MST