qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	kvm@vger.kernel.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
	qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
	avi@redhat.com, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property
Date: Mon, 18 Jun 2012 15:05:04 +0300	[thread overview]
Message-ID: <20120618120503.GA25390@redhat.com> (raw)
In-Reply-To: <877gygqhbp.fsf@rustcorp.com.au>

On Tue, Mar 20, 2012 at 10:22:42AM +1030, Rusty Russell wrote:
> On Mon, 19 Mar 2012 17:13:06 -0500, Anthony Liguori <anthony@codemonkey.ws> wrote:
> > > Maybe just make this a hidden option like x-miio?
> > 
> > x-violate-the-virtio-spec-to-trick-old-linux-drivers-into-working-on-power?
> 
> "To configure the device, we use the first I/O region of the PCI
> device."
> 
> Meh, it does sound a little like we are specifying that it's an PCI I/O
> bar.
> 
> Let's resurrect the PCI-v2 idea, which is ready to implement now, and a
> nice cleanup?  Detach it from the change-of-ring-format idea which is
> turning out to be a tarpit.
> 
> Thanks,
> Rusty.

Yes. But it seems silly to even write code to play with device config in
memory when we agreed the right thing to do is to use a config vq
everywhere.

Now a question: does a oconfig vq look like a PCI specific
feature to you, a work-around for lack of multibyte atomic
accesses? If yes it's sane to make it a PCI capability.
Or is it something most transports would need? If yes we
need a feature bit and this is a chicken and egg problem ...

> -- 
>   How could I marry someone with more hair than me?  http://baldalex.org

      parent reply	other threads:[~2012-06-18 12:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 15:56 [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property Michael S. Tsirkin
2012-03-19 17:58 ` Avi Kivity
2012-03-19 18:57   ` Michael S. Tsirkin
2012-03-20 14:49     ` Avi Kivity
2012-03-19 19:19 ` Anthony Liguori
2012-03-19 20:49   ` Michael S. Tsirkin
2012-03-19 21:07     ` Anthony Liguori
2012-03-19 21:20       ` Michael S. Tsirkin
2012-03-19 21:29       ` Michael S. Tsirkin
2012-03-19 22:13         ` Anthony Liguori
2012-03-19 23:52           ` Rusty Russell
2012-03-20  0:39             ` Anthony Liguori
2012-06-18 12:05             ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120618120503.GA25390@redhat.com \
    --to=mst@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=aliguori@us.ibm.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).