qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Crístian Viana" <vianac@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	QEMU Development ML <qemu-devel@nongnu.org>,
	Anthony Liguori <anthony@codemonkey.ws>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/2] Force driftfix=none on previous machines
Date: Wed, 20 Jun 2012 09:34:02 +0100	[thread overview]
Message-ID: <20120620083402.GD20792@redhat.com> (raw)
In-Reply-To: <1340134725-28764-1-git-send-email-vianac@linux.vnet.ibm.com>

On Tue, Jun 19, 2012 at 04:38:44PM -0300, Crístian Viana wrote:
> The current value for the -rtc driftfix option is 'none'. This patch
> makes sure that the old machines configuration will work the same way
> even after that option changes its default value.
> 
> Signed-off-by: Crístian Viana <vianac@linux.vnet.ibm.com>
> ---
> 
> There's a scenario when things don't work the way I expected: when I set a
> previous machine with -M, the driftfix flag value on the command line is not
> used, the machine's default value overwrites it. I'm not sure if that's the
> expected behavior of QEMU in those cases (if I set a machine, I can't change its
> properties) or if there's a bug somewhere. This is the question I asked in a
> previous e-mail (http://article.gmane.org/gmane.comp.emulators.qemu/149902).
> 
> For example,
> 
> $ x86_64-softmmu/qemu-x86_64 -M pc-1.0 --rtc driftfix=slew
> 
> will use "driftfix=none", which is the default for the machine pc-1.0, not
> "driftfix=slew" as I set on the command line. That only happens if I choose
> a different machine than the default one (pc-1.1 as of now); otherwise it
> works fine.

I can't answer your question as to why this happens, but this is a
critical problem we must fix before merging this change. We need to
be able to set driftfix=slew for old machine types manually.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

      parent reply	other threads:[~2012-06-20  8:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 19:38 [Qemu-devel] [PATCH v4 1/2] Force driftfix=none on previous machines Crístian Viana
2012-06-19 19:38 ` [Qemu-devel] [PATCH v4 2/2] Change driftfix default value to slew Crístian Viana
2012-06-20  8:34 ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120620083402.GD20792@redhat.com \
    --to=berrange@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=vianac@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).