From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShGMm-0001mt-UD for qemu-devel@nongnu.org; Wed, 20 Jun 2012 04:34:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShGMg-0005cP-G1 for qemu-devel@nongnu.org; Wed, 20 Jun 2012 04:34:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShGMg-0005cG-8V for qemu-devel@nongnu.org; Wed, 20 Jun 2012 04:34:14 -0400 Date: Wed, 20 Jun 2012 09:34:02 +0100 From: "Daniel P. Berrange" Message-ID: <20120620083402.GD20792@redhat.com> References: <1340134725-28764-1-git-send-email-vianac@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1340134725-28764-1-git-send-email-vianac@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/2] Force driftfix=none on previous machines Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?Q3LDrXN0aWFu?= Viana Cc: Paolo Bonzini , QEMU Development ML , Anthony Liguori , Stefano Stabellini On Tue, Jun 19, 2012 at 04:38:44PM -0300, Cr=C3=ADstian Viana wrote: > The current value for the -rtc driftfix option is 'none'. This patch > makes sure that the old machines configuration will work the same way > even after that option changes its default value. >=20 > Signed-off-by: Cr=C3=ADstian Viana > --- >=20 > There's a scenario when things don't work the way I expected: when I se= t a > previous machine with -M, the driftfix flag value on the command line i= s not > used, the machine's default value overwrites it. I'm not sure if that's= the > expected behavior of QEMU in those cases (if I set a machine, I can't c= hange its > properties) or if there's a bug somewhere. This is the question I asked= in a > previous e-mail (http://article.gmane.org/gmane.comp.emulators.qemu/149= 902). >=20 > For example, >=20 > $ x86_64-softmmu/qemu-x86_64 -M pc-1.0 --rtc driftfix=3Dslew >=20 > will use "driftfix=3Dnone", which is the default for the machine pc-1.0= , not > "driftfix=3Dslew" as I set on the command line. That only happens if I = choose > a different machine than the default one (pc-1.1 as of now); otherwise = it > works fine. I can't answer your question as to why this happens, but this is a critical problem we must fix before merging this change. We need to be able to set driftfix=3Dslew for old machine types manually. Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|