From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKZO-0006tj-OS for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:03:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShKZE-0003oP-Nb for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:03:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKZE-0003o6-Fn for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:03:28 -0400 Date: Wed, 20 Jun 2012 14:03:22 +0100 From: "Daniel P. Berrange" Message-ID: <20120620130322.GT20792@redhat.com> References: <20120620091528.GI20792@redhat.com> <4FE1C90D.7090908@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4FE1C90D.7090908@codemonkey.ws> Subject: Re: [Qemu-devel] Threaded VNC server status - time to enable by default ? Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel On Wed, Jun 20, 2012 at 07:58:53AM -0500, Anthony Liguori wrote: > On 06/20/2012 04:15 AM, Daniel P. Berrange wrote: > >We recently had a request in Fedora to enable the VNC server thread > >support in our builds of QEMU. There have been periodic messages on > >this list that suggest the threaded VNC server has better performance > >and less latency. > > > >My view though, is that there must be some good reason why QEMU does > >not enable it by default already. Can anyone say why QEMU has not > >enabled the VNC server threads by default ? > > > >If there is no such reason, can we just kill the configure options > >--{disable,enable}-vnc-thread, and have everyone use the VNC server > >thread support forever more. I struggle to see the point in maintaining > >these two separate codepaths for the VNC server. Whichever one is > >not the default is, IMHO, destined to bitrot through lack of widespread > >testing and so we're better off getting everyone to use& test the > >same codepath. > > At the time it was introduced, QEMU still has no hard requirement on > having pthreads as a dependency (the I/O thread was still optional). > > We're past that point now so there's no harm in unconditionally > enabling the VNC thread pool. Ok, I'll post a patch to that effect. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|