From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShSdW-00087N-Mb for qemu-devel@nongnu.org; Wed, 20 Jun 2012 17:40:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShSdV-0001Le-2p for qemu-devel@nongnu.org; Wed, 20 Jun 2012 17:40:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShSdU-0001L3-Qu for qemu-devel@nongnu.org; Wed, 20 Jun 2012 17:40:24 -0400 Date: Thu, 21 Jun 2012 00:40:03 +0300 From: "Michael S. Tsirkin" Message-ID: <20120620214003.GC25850@redhat.com> References: <1340087992-2399-1-git-send-email-benh@kernel.crashing.org> <1340087992-2399-4-git-send-email-benh@kernel.crashing.org> <4FE23DBF.9040706@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FE23DBF.9040706@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Richard Henderson , Eduard - Gabriel Munteanu , qemu-devel@nongnu.org, David Gibson On Wed, Jun 20, 2012 at 04:16:47PM -0500, Anthony Liguori wrote: > >diff --git a/qemu-common.h b/qemu-common.h > >index 8f87e41..80026af 100644 > >--- a/qemu-common.h > >+++ b/qemu-common.h > >@@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier; > > typedef struct VirtIODevice VirtIODevice; > > typedef struct QEMUSGList QEMUSGList; > > typedef struct SHPCDevice SHPCDevice; > >+typedef struct DMAContext DMAContext; > > Please don't put this in qemu-common.h. Stick it in a dma-specific header. Weird. The point of typedefs in qemu-common.h is so people can use type pointer *without pulling in the relevant header*. If we put a typedef in specific header it defeats the purpose. It used to even say this somewhere so I don't remember where. -- MST