From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShWf9-0003aI-Di for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShWf4-0002JI-JQ for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:22 -0400 Received: from ozlabs.org ([203.10.76.45]:53937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShWf4-0002Ic-6m for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:18 -0400 Date: Thu, 21 Jun 2012 11:42:25 +1000 From: David Gibson Message-ID: <20120621014225.GA12749@truffala.fritz.box> References: <1340087992-2399-1-git-send-email-benh@kernel.crashing.org> <1340087992-2399-8-git-send-email-benh@kernel.crashing.org> <4FE081CE.1060001@redhat.com> <1340137438.28143.28.camel@pasglop> <20120620031421.GB9144@truffala.fritz.box> <1340164332.28143.66.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340164332.28143.66.camel@pasglop> Subject: Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Gerd Hoffmann , anthony@codemonkey.ws, qemu-devel@nongnu.org On Wed, Jun 20, 2012 at 01:52:12PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-20 at 13:14 +1000, David Gibson wrote: > > So, in fact the original comment is a bit out of date. With the > > current version of this series, then a guest attempt to invalidate > > will be delayed until the unmap occurs. > > No, this code was dropped, including the tracking of the maps, following > comments from Anthony and others. The API for providing a cancel > callback is still there but nothing will call it unless the backend does > its own tracking and decides to do so. Ah, right. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson