From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShWf6-0003Zw-AU for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShWf4-0002JB-Ie for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:19 -0400 Received: from ozlabs.org ([203.10.76.45]:58293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShWf4-0002Id-6p for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:18 -0400 Date: Thu, 21 Jun 2012 11:44:11 +1000 From: David Gibson Message-ID: <20120621014411.GB12749@truffala.fritz.box> References: <1340087992-2399-1-git-send-email-benh@kernel.crashing.org> <1340087992-2399-2-git-send-email-benh@kernel.crashing.org> <4FE23D1F.3090408@codemonkey.ws> <1340227763.28143.170.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340227763.28143.170.camel@pasglop> Subject: Re: [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-devel@nongnu.org, Anthony Liguori On Thu, Jun 21, 2012 at 07:29:23AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-20 at 16:14 -0500, Anthony Liguori wrote: > > > Why not make life easy and fix dma_addr_t to 64-bit? > > No opinion on my side, that's from the original patch series, I suppose > the goal was to avoid the overhead/bloat on 32-bit only > platforms/targets. More or less. I think I do set it to 64-bit later in the series. Particularly when IOMMU was configurable off, I had it set to target_phys_addr_t given people's propensity to bitch and moan about the slightest theoretical bloat. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson