From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49652)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1ShWf6-0003Zx-E3
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1ShWf4-0002J6-IT
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:20 -0400
Received: from ozlabs.org ([203.10.76.45]:33354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1ShWf4-0002If-6i
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 21:58:18 -0400
Date: Thu, 21 Jun 2012 11:45:14 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20120621014514.GC12749@truffala.fritz.box>
References: <1340087992-2399-1-git-send-email-benh@kernel.crashing.org>
	<1340087992-2399-3-git-send-email-benh@kernel.crashing.org>
	<4FE23D61.3030000@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FE23D61.3030000@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Wed, Jun 20, 2012 at 04:15:13PM -0500, Anthony Liguori wrote:
> On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote:
> >From: David Gibson<david@gibson.dropbear.id.au>
> >
> >This patch adds cpu_physical_memory_set() function.  This is equivalent to
> >calling cpu_physical_memory_write() with a buffer filled with a character,
> >ie, a memset of target memory.
> >
> >It uses a small temporary buffer on the stack.
> >
> >Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
> >Signed-off-by: Benjamin Herrenschmidt<benh@kernel.crashing.org>
> 
> Why should this be in the core API?  Shouldn't this be a helper on
> top of the DMA API?

Well, I was hoping to avoid having to allocate a temporary buffer of
zeroes, which is necessary to do this in terms of the existing
cpu_physical_memory_write() api.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson