From: David Gibson <david@gibson.dropbear.id.au>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Richard Henderson <rth@twiddle.net>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions
Date: Thu, 21 Jun 2012 11:48:04 +1000 [thread overview]
Message-ID: <20120621014804.GE12749@truffala.fritz.box> (raw)
In-Reply-To: <4FE23DBF.9040706@codemonkey.ws>
On Wed, Jun 20, 2012 at 04:16:47PM -0500, Anthony Liguori wrote:
[snip]
> >diff --git a/qemu-common.h b/qemu-common.h
> >index 8f87e41..80026af 100644
> >--- a/qemu-common.h
> >+++ b/qemu-common.h
> >@@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier;
> > typedef struct VirtIODevice VirtIODevice;
> > typedef struct QEMUSGList QEMUSGList;
> > typedef struct SHPCDevice SHPCDevice;
> >+typedef struct DMAContext DMAContext;
>
> Please don't put this in qemu-common.h. Stick it in a dma-specific
> header.
I'm pretty sure I started to hit circular include hell without the
forward declaration here.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-06-21 1:58 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 6:39 [Qemu-devel] [PATCH 00/13] iommu series Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 01/13] Better support for dma_addr_t variables Benjamin Herrenschmidt
2012-06-20 21:14 ` Anthony Liguori
2012-06-20 21:29 ` Benjamin Herrenschmidt
2012-06-21 1:44 ` David Gibson
2012-06-20 22:26 ` Peter Maydell
2012-06-20 22:59 ` Anthony Liguori
2012-06-21 7:54 ` Peter Maydell
2012-06-22 1:58 ` Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set() Benjamin Herrenschmidt
2012-06-20 21:15 ` Anthony Liguori
2012-06-20 21:30 ` Benjamin Herrenschmidt
2012-06-20 21:37 ` Anthony Liguori
2012-06-21 1:45 ` David Gibson
2012-06-21 1:46 ` David Gibson
2012-06-21 2:50 ` Benjamin Herrenschmidt
2012-06-22 1:58 ` Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions Benjamin Herrenschmidt
2012-06-20 21:16 ` Anthony Liguori
2012-06-20 21:32 ` Michael S. Tsirkin
2012-06-20 21:38 ` Anthony Liguori
2012-06-20 21:42 ` Michael S. Tsirkin
2012-06-20 21:46 ` Anthony Liguori
2012-06-20 22:00 ` Michael S. Tsirkin
2012-06-20 21:33 ` Benjamin Herrenschmidt
2012-06-20 21:40 ` Michael S. Tsirkin
2012-06-20 22:01 ` Anthony Liguori
2012-06-21 1:48 ` David Gibson [this message]
2012-06-22 2:02 ` Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 04/13] usb-ohci: Use " Benjamin Herrenschmidt
2012-06-20 21:18 ` Anthony Liguori
2012-06-20 21:36 ` Benjamin Herrenschmidt
2012-06-20 21:40 ` Anthony Liguori
2012-06-20 22:02 ` Benjamin Herrenschmidt
2012-06-21 7:33 ` Michael S. Tsirkin
2012-06-21 12:55 ` Anthony Liguori
2012-06-21 14:10 ` Michael S. Tsirkin
2012-06-22 2:28 ` Benjamin Herrenschmidt
2012-06-21 6:43 ` Gerd Hoffmann
2012-06-19 6:39 ` [Qemu-devel] [PATCH 05/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers Benjamin Herrenschmidt
2012-06-20 21:21 ` Anthony Liguori
2012-06-20 21:37 ` Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 06/13] ide/ahci: Use universal DMA helper functions Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers Benjamin Herrenschmidt
2012-06-19 13:42 ` Gerd Hoffmann
2012-06-19 20:23 ` Benjamin Herrenschmidt
2012-06-20 3:14 ` David Gibson
2012-06-20 3:52 ` Benjamin Herrenschmidt
2012-06-21 1:42 ` David Gibson
2012-06-20 6:25 ` Gerd Hoffmann
2012-06-20 9:25 ` Benjamin Herrenschmidt
2012-06-20 9:54 ` Gerd Hoffmann
2012-06-19 6:39 ` [Qemu-devel] [PATCH 08/13] iommu: Introduce IOMMU emulation infrastructure Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 09/13] iommu: Add facility to cancel in-use dma memory maps Benjamin Herrenschmidt
2012-06-20 21:25 ` Anthony Liguori
2012-06-20 21:52 ` Benjamin Herrenschmidt
2012-06-22 3:18 ` Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 10/13] pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 11/13] iommu: Allow PCI to use " Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 12/13] pseries: Implement IOMMU and DMA for PAPR PCI devices Benjamin Herrenschmidt
2012-06-19 6:39 ` [Qemu-devel] [PATCH 13/13] Add a memory barrier to DMA functions Benjamin Herrenschmidt
2012-06-20 21:12 ` [Qemu-devel] [PATCH 00/13] iommu series Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2012-05-10 4:48 [Qemu-devel] [PATCH 00/13] IOMMU infrastructure Benjamin Herrenschmidt
2012-05-10 4:48 ` [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621014804.GE12749@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=anthony@codemonkey.ws \
--cc=eduard.munteanu@linux360.ro \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).