From: "Daniel P. Berrange" <berrange@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server
Date: Thu, 21 Jun 2012 10:59:27 +0100 [thread overview]
Message-ID: <20120621095927.GI21124@redhat.com> (raw)
In-Reply-To: <4FE2F018.60109@msgid.tls.msk.ru>
On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote:
> 20.06.2012 16:24, Daniel P. Berrange wrote:
> > delete mode 100644 ui/vnc-jobs-async.c
> > delete mode 100644 ui/vnc-jobs-sync.c
> > create mode 100644 ui/vnc-jobs.c
>
> Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ?
The corresponding header file is vnc-jobs.h, and since we only
have one impl of it now, using the same name is normal practice.
> I'd leave it alone at this stage, omiting just the rename...
I disagree, GIT handles renames like this fine, so there's no
reason not to do this.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2012-06-21 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 13:24 [Qemu-devel] [PATCH] Remove support for non-threaded VNC server Daniel P. Berrange
2012-06-21 9:57 ` Michael Tokarev
2012-06-21 9:59 ` Daniel P. Berrange [this message]
2012-06-21 10:23 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621095927.GI21124@redhat.com \
--to=berrange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).