From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SheAv-0006ki-Ll for qemu-devel@nongnu.org; Thu, 21 Jun 2012 05:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SheAn-0006Nt-6X for qemu-devel@nongnu.org; Thu, 21 Jun 2012 05:59:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SheAm-0006NX-Uf for qemu-devel@nongnu.org; Thu, 21 Jun 2012 05:59:33 -0400 Date: Thu, 21 Jun 2012 10:59:27 +0100 From: "Daniel P. Berrange" Message-ID: <20120621095927.GI21124@redhat.com> References: <1340198668-21307-1-git-send-email-berrange@redhat.com> <4FE2F018.60109@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4FE2F018.60109@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Anthony Liguori , qemu-devel@nongnu.org On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote: > 20.06.2012 16:24, Daniel P. Berrange wrote: > > delete mode 100644 ui/vnc-jobs-async.c > > delete mode 100644 ui/vnc-jobs-sync.c > > create mode 100644 ui/vnc-jobs.c > > Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ? The corresponding header file is vnc-jobs.h, and since we only have one impl of it now, using the same name is normal practice. > I'd leave it alone at this stage, omiting just the rename... I disagree, GIT handles renames like this fine, so there's no reason not to do this. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|