From: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, Jia Liu <proljc@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 00/16] QEMU OpenRISC support
Date: Fri, 22 Jun 2012 11:16:57 +0800 [thread overview]
Message-ID: <20120622031657.GA55960@cs.nctu.edu.tw> (raw)
In-Reply-To: <CAFEAcA-iKh3k6z_W9_mH7bzr4xgbhhq-7nObDCCD16Rt2FBCdg@mail.gmail.com>
On Thu, Jun 21, 2012 at 06:28:30PM +0100, Peter Maydell wrote:
> On 21 June 2012 18:24, Blue Swirl <blauwirbel@gmail.com> wrote:
> > On Wed, Jun 20, 2012 at 7:10 AM, Jia Liu <proljc@gmail.com> wrote:
> >> ERROR: need consistent spacing around '*' (ctx:WxV)
> >> #99: FILE: target-openrisc/int_helper.c:53:
> >> +target_ulong HELPER(mul32)(CPUOpenRISCState *env,
> >>
> >> It is really weird. And, I don't know how to handle it.
> >
> > It's a limitation in checkpatch.pl, it is confused by any CPUxxxState
> > for some reason. Please just ignore these cases.
>
> I think in this case it's more likely to be the HELPER() macro
> that is confusing it, but yes, just ignore the error.
Should this be added to http://wiki.qemu.org/Contribute/SubmitAPatch
as an example? I remember someone else had the same problem before.
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
prev parent reply other threads:[~2012-06-22 3:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 1:02 [Qemu-devel] [PATCH v5 00/16] QEMU OpenRISC support Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 01/16] target-or32: Add target stubs and cpu support Jia Liu
2012-06-18 18:28 ` Blue Swirl
2012-06-20 7:14 ` Jia Liu
2012-06-21 17:30 ` Blue Swirl
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 02/16] target-or32: Add target machine Jia Liu
2012-06-18 18:24 ` Blue Swirl
2012-06-20 7:19 ` Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 03/16] target-or32: Add MMU support Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 04/16] target-or32: Add interrupt support Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 05/16] target-or32: Add exception support Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 06/16] target-or32: Add int instruction helpers Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 07/16] target-or32: Add float " Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 08/16] target-or32: Add translation routines Jia Liu
2012-06-18 18:40 ` Blue Swirl
2012-06-19 8:05 ` Jia Liu
2012-06-19 18:33 ` Blue Swirl
2012-06-19 23:11 ` Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 09/16] target-or32: Add PIC support Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 10/16] target-or32: Add timer support Jia Liu
2012-06-18 1:02 ` [Qemu-devel] [PATCH v5 11/16] target-or32: Add a IIS dummy board Jia Liu
2012-06-20 6:29 ` Max Filippov
2012-06-20 9:42 ` Jia Liu
2012-06-20 12:57 ` Max Filippov
2012-06-20 16:41 ` Jia Liu
2012-06-20 20:07 ` Max Filippov
2012-06-20 20:10 ` [Qemu-devel] [PATCH] target-or32: replace NE2000 with OpenCores 10/100 ethernet adapter Max Filippov
2012-06-21 1:54 ` Jia Liu
2012-06-18 1:03 ` [Qemu-devel] [PATCH v5 12/16] target-or32: Add system instructions Jia Liu
2012-06-18 18:58 ` Blue Swirl
2012-06-19 8:02 ` Jia Liu
2012-06-19 18:25 ` Blue Swirl
2012-06-20 0:17 ` Jia Liu
2012-06-18 1:03 ` [Qemu-devel] [PATCH v5 13/16] target-or32: Add gdb stub support Jia Liu
2012-06-18 1:03 ` [Qemu-devel] [PATCH v5 14/16] target-or32: Add linux syscall, signal and termbits Jia Liu
2012-06-18 1:03 ` [Qemu-devel] [PATCH v5 15/16] target-or32: Add linux user support Jia Liu
2012-06-18 1:03 ` [Qemu-devel] [PATCH v5 16/16] target-or32: Add testcases Jia Liu
2012-06-18 19:11 ` [Qemu-devel] [PATCH v5 00/16] QEMU OpenRISC support Blue Swirl
2012-06-20 7:10 ` Jia Liu
2012-06-21 17:24 ` Blue Swirl
2012-06-21 17:28 ` Peter Maydell
2012-06-22 3:16 ` 陳韋任 (Wei-Ren Chen) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622031657.GA55960@cs.nctu.edu.tw \
--to=chenwj@iis.sinica.edu.tw \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).