From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>
Cc: qemu-trivial@nongnu.org, edgar.iglesias@gmail.com,
qemu-devel@nongnu.org, john.williams@petalogix.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v1] device_tree: load_device_tree(): Allow NULL sizep
Date: Fri, 22 Jun 2012 10:15:55 +0100 [thread overview]
Message-ID: <20120622091555.GF27038@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1340254284-20415-1-git-send-email-peter.crosthwaite@petalogix.com>
On Thu, Jun 21, 2012 at 02:51:24PM +1000, Peter A. G. Crosthwaite wrote:
> The sizep arg is populated with the size of the loaded device tree. Since this
> is one of those informational "please populate" type arguments it should be
> optional. Guarded writes to *sizep against NULL accordingly.
>
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com>
> ---
> device_tree.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
Can someone who knows device trees review this?
All current users need the size in order to copy the fdt into guest
memory. Why should the size argument be optional?
Stefan
next prev parent reply other threads:[~2012-06-22 9:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 4:51 [Qemu-devel] [PATCH v1] device_tree: load_device_tree(): Allow NULL sizep Peter A. G. Crosthwaite
2012-06-22 9:15 ` Stefan Hajnoczi [this message]
2012-06-22 10:24 ` [Qemu-devel] [Qemu-trivial] " Peter Crosthwaite
2012-06-22 12:28 ` Stefan Hajnoczi
2012-06-22 13:17 ` [Qemu-devel] " Peter Crosthwaite
2012-06-22 21:14 ` Alexander Graf
2012-06-23 0:45 ` Peter Crosthwaite
2012-06-23 10:01 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622091555.GF27038@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=john.williams@petalogix.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).