From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1SldVE-000699-M0
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 06:05:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1SldVC-00040w-Vu
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 06:05:08 -0400
Received: from e28smtp08.in.ibm.com ([122.248.162.8]:50312)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bharata@linux.vnet.ibm.com>) id 1SldVC-0003oV-Af
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 06:05:06 -0400
Received: from /spool/local
	by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <bharata@linux.vnet.ibm.com>;
	Mon, 2 Jul 2012 15:34:48 +0530
Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67])
	by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q62A4cM78913278
	for <qemu-devel@nongnu.org>; Mon, 2 Jul 2012 15:34:39 +0530
Received: from d28av05.in.ibm.com (loopback [127.0.0.1])
	by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q62FZCLP010331
	for <qemu-devel@nongnu.org>; Tue, 3 Jul 2012 01:35:12 +1000
Date: Mon, 2 Jul 2012 15:35:38 +0530
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Message-ID: <20120702100537.GA15112@in.ibm.com>
References: <20120611141806.GA2737@in.ibm.com>
	<20120611142026.GC2737@in.ibm.com>
	<CAJSP0QXW5q2=0hweymTAEeoh+RLWjR=9sBDdcECQwtzjZSzPeA@mail.gmail.com>
	<20120619093116.GD27963@in.ibm.com> <4FF16F44.2040303@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FF16F44.2040303@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to
 interface with libglusterfs
Reply-To: bharata@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, Vijay Bellur <vbellur@redhat.com>

On Mon, Jul 02, 2012 at 11:52:04AM +0200, Paolo Bonzini wrote:
> Il 19/06/2012 11:31, Bharata B Rao ha scritto:
> >>> > > +    ret = pthread_create(&thread, NULL, gluster_handle_poll,
> >>> > > +    (void *)gctx);
> >> > 
> >> > Please use qemu-thread.h.  QEMU uses signals so you almost certainly
> >> > want to mask signals for this thread (qemu_thread_create() does that).
> > Ok. This is temporary since this entire patch (2/3) would be redundant
> > when we have libglusterfsclient working.
> 
> Please make sure that libglusterfsclient also masks signals for its own
> threads.  It's a pretty common source of bugs with threaded libraries,
> and masking the signals is harmless for programs that do not care.

Will take care of this. Thanks for your review.

Regards,
Bharata.