From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlgV7-0005v0-Tb for qemu-devel@nongnu.org; Mon, 02 Jul 2012 09:17:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlgUu-00059K-Fm for qemu-devel@nongnu.org; Mon, 02 Jul 2012 09:17:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlgUu-00058B-5F for qemu-devel@nongnu.org; Mon, 02 Jul 2012 09:17:00 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q62DGwMn023555 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Jul 2012 09:16:59 -0400 Date: Mon, 2 Jul 2012 10:17:29 -0300 From: Luiz Capitulino Message-ID: <20120702101729.6a9950fa@doriath.home> In-Reply-To: <4FF05199.2090305@redhat.com> References: <1339575768-2557-1-git-send-email-lersek@redhat.com> <4FD8716C.3030503@redhat.com> <4FF05199.2090305@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Laszlo Ersek , qemu-devel@nongnu.org On Sun, 01 Jul 2012 15:33:13 +0200 Paolo Bonzini wrote: > Il 13/06/2012 12:54, Paolo Bonzini ha scritto: > > Il 13/06/2012 10:22, Laszlo Ersek ha scritto: > >> Inspired by [1], the first half of this series attempts to implement a new > >> visitor that should clean up defining and processing command line options. > >> For a more detailed description, please see "[PATCH 05/17] qapi: introduce > >> OptsVisitor". > >> > >> The second half converts -net/-netdev parsing to the new visitor. > >> > >> v1->v2: > >> - Insert a small patch between v1 01/16 and v1 02/16 in order to generate > >> C types for fixed-width integers. > >> - Tighten / clean up integer types in Netdev options and in OptsVisitor. > >> - NetLegacy::name is optional. > >> - Changes are marked below individually and described separately. > >> - (Rebase to current master.) > > > > Looks good, thanks! > > Luiz, what's the state of this? Hmm, I've missed this one. Sorry for that. I'll be off for a few days starting the day after tomorrow. I'll try to review it before that.