From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smnvl-0005Yn-6x for qemu-devel@nongnu.org; Thu, 05 Jul 2012 11:25:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Smnve-0004mi-0V for qemu-devel@nongnu.org; Thu, 05 Jul 2012 11:25:20 -0400 Date: Thu, 5 Jul 2012 18:25:28 +0300 From: "Michael S. Tsirkin" Message-ID: <20120705152528.GD31257@redhat.com> References: <1341422373-13614-1-git-send-email-afaerber@suse.de> <1341422373-13614-2-git-send-email-afaerber@suse.de> <20120704212050.GD27653@redhat.com> <4FF4C8E0.7020700@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <4FF4C8E0.7020700@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 01/14] pci: Make host bridge TypeInfos const List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: jbaron@redhat.com, qemu-devel@nongnu.org, Alexander Graf , qemu-ppc , anthony@codemonkey.ws, pbonzini@redhat.com On Thu, Jul 05, 2012 at 12:51:12AM +0200, Andreas F=E4rber wrote: > Am 04.07.2012 23:20, schrieb Michael S. Tsirkin: > > On Wed, Jul 04, 2012 at 07:19:20PM +0200, Andreas F=E4rber wrote: > >> Also give the sPAPR host bridge type registration functions a unique > >> name. > >> > >> Signed-off-by: Andreas F=E4rber > >=20 > > I'd like to note that this is a bad practice. > > Yoy write one thing in the 1 line summary > > and then in the full commit log you > > write about other unrelated stuff. >=20 > (It seemed related by the proximity to the TypeInfo fwiw.) >=20 > > Make it a separate patch. >=20 > Do you request that for Coding Style fixes, too? See QOM'ify prep_pci > for an example that removed the only remaining violations in the file > while touching code above and below. >=20 > Background of why v2 already did multiple things at once (without anyon= e > complaining) was that Anthony complained that my CPU refactorings were > too long and not doing enough in one patch. >=20 > I'm already up from 2 to 14 here and don't mind splitting things up > further again but I don't think there's sufficient reason that warrants > having a patch that just renames the function for aesthetics. Would you > be okay with moving it into the corresponding QOM'ify sPAPR patch or th= e > final "Tidy up" patch instead? >=20 > Andreas You can even leave it as is, but subject should then say 'misc cleanups in XXXX.c' ot something to that effect. > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg >=20