From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smw2o-0003n2-5W for qemu-devel@nongnu.org; Thu, 05 Jul 2012 20:05:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Smw2m-0008C3-Et for qemu-devel@nongnu.org; Thu, 05 Jul 2012 20:05:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Smw2m-0008AU-78 for qemu-devel@nongnu.org; Thu, 05 Jul 2012 20:05:08 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q66056WM014420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Jul 2012 20:05:06 -0400 Date: Thu, 5 Jul 2012 21:04:18 -0300 From: Marcelo Tosatti Message-ID: <20120706000418.GB7150@amt.cnet> References: <201205042123.q44LNp9x029061@int-mx01.intmail.prod.int.phx2.redhat.com> <20120521175335.GD3353@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120521175335.GD3353@redhat.com> Subject: Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: avi@redhat.com, qemu-devel@nongnu.org On Mon, May 21, 2012 at 01:53:36PM -0400, Jason Baron wrote: > On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: > > Add a command line parameter to not dump guest memory in the core dump, the > > command line is: -dont-dump-guest. This brought the core dump down from > > 383MB to 13 MB on a 1GB guest. > > > > Signed-off-by: Jason Baron > > --- > > exec.c | 13 +++++++++++++ > > osdep.h | 7 +++++++ > > qemu-options.hx | 5 +++++ > > sysemu.h | 1 + > > vl.c | 4 ++++ > > 5 files changed, 30 insertions(+), 0 deletions(-) > > > > Any thoughts on this? Is the guest memory often helpful in debugging > when the qemu process segfaults? For most development related usage, no (with large guests, its troublesome). Please add documentation for the command (patch looks fine otherwise). > This feature also seems useful if somebody is running a sensitive > workload, such that the non-sensitive qemu state can be dumped > independently of the guest state. In that case, perhaps there should > also be an option that allows the guest to be dumped on a segfault, now > separately? Isnt what this option does? (well, disabling it).