From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33836)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1Soynm-00089Q-Iu
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:26:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1Soyng-00005b-86
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:26:06 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:41165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1Soynf-00004t-Uo
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 11:26:00 -0400
Received: by pbbro12 with SMTP id ro12so2280709pbb.4
	for <qemu-devel@nongnu.org>; Wed, 11 Jul 2012 08:25:57 -0700 (PDT)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 11 Jul 2012 10:25:46 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120711152546.GA2941@illuin>
References: <1342017621-12650-1-git-send-email-pbonzini@redhat.com>
	<1342017621-12650-2-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1342017621-12650-2-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files
 in qga/Makefile.objs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com

On Wed, Jul 11, 2012 at 04:40:20PM +0200, Paolo Bonzini wrote:
> No reason to leave them out, and it will ensure that the dependencies
> are picked up.  Later we can perhaps move the files to another
> directory to avoid ../ usage.

Couldn't we accomplish that by just adding the dependencies to qga-obj-y in
the top-level Makefile.objs instead?

> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile          |    2 +-
>  qga/Makefile.objs |    2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 34d6a9e..1b7cd2f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -206,7 +206,7 @@ QGALIB_GEN=$(addprefix qapi-generated/, qga-qapi-types.h qga-qapi-visit.h qga-qm
>  $(QGALIB_OBJ): $(QGALIB_GEN)
>  $(qga-obj-y) qemu-ga.o: $(QGALIB_GEN)
> 
> -qemu-ga$(EXESUF): qemu-ga.o $(qga-obj-y) $(tools-obj-y) $(qapi-obj-y) $(qobject-obj-y) $(version-obj-y) $(QGALIB_OBJ)
> +qemu-ga$(EXESUF): qemu-ga.o $(qga-obj-y) $(tools-obj-y) $(qapi-obj-y) $(qobject-obj-y) $(version-obj-y)
> 
>  QEMULIBS=libhw32 libhw64 libuser libdis libdis-user
> 
> diff --git a/qga/Makefile.objs b/qga/Makefile.objs
> index 6a4d843..b54b9b1 100644
> --- a/qga/Makefile.objs
> +++ b/qga/Makefile.objs
> @@ -1,3 +1,5 @@
>  qga-obj-y = commands.o guest-agent-command-state.o
>  qga-obj-$(CONFIG_POSIX) += commands-posix.o channel-posix.o
>  qga-obj-$(CONFIG_WIN32) += commands-win32.o channel-win32.o service-win32.o
> +qga-obj-y += ../qapi-generated/qga-qapi-types.o ../qapi-generated/qga-qapi-visit.o
> +qga-obj-y += ../qapi-generated/qga-qmp-marshal.o
> -- 
> 1.7.10.4
> 
> 
>