From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SozLp-0001rt-Gm for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SozLf-0003nD-M7 for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:01:17 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:41119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SozLf-0003mw-Dy for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:01:07 -0400 Received: by pbbro12 with SMTP id ro12so2324943pbb.4 for ; Wed, 11 Jul 2012 09:01:05 -0700 (PDT) Sender: fluxion Date: Wed, 11 Jul 2012 11:00:54 -0500 From: Michael Roth Message-ID: <20120711160054.GB2941@illuin> References: <1342017621-12650-1-git-send-email-pbonzini@redhat.com> <1342017621-12650-2-git-send-email-pbonzini@redhat.com> <20120711152546.GA2941@illuin> <4FFD9B9A.4060305@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FFD9B9A.4060305@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] build: include qapi-generated/ files in qga/Makefile.objs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com On Wed, Jul 11, 2012 at 05:28:26PM +0200, Paolo Bonzini wrote: > Il 11/07/2012 17:25, Michael Roth ha scritto: > > > No reason to leave them out, and it will ensure that the dependencies > > > are picked up. Later we can perhaps move the files to another > > > directory to avoid ../ usage. > > > > Couldn't we accomplish that by just adding the dependencies to qga-obj-y in > > the top-level Makefile.objs instead? > > Yes, but I believe that the better place for these files is > qga/qapi-generated/, so I'm preparing for that. :) Ah, makes sense :) Reviewed-by: Michael Roth > > Paolo >