From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpD2v-00033U-1I for qemu-devel@nongnu.org; Thu, 12 Jul 2012 02:38:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SpD2p-0001Cx-FD for qemu-devel@nongnu.org; Thu, 12 Jul 2012 02:38:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SpD2p-0001Cr-6u for qemu-devel@nongnu.org; Thu, 12 Jul 2012 02:38:35 -0400 Date: Thu, 12 Jul 2012 09:38:27 +0300 From: Gleb Natapov Message-ID: <20120712063827.GA31602@redhat.com> References: <1341926152-541-1-git-send-email-imammedo@redhat.com> <1341926152-541-2-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1341926152-541-2-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Tue, Jul 10, 2012 at 03:15:51PM +0200, Igor Mammedov wrote: > /* pc.c */ > -int cpu_is_bsp(CPUX86State *env); Why remove it instead of modifying it to check BSP bit in apic base? I think it will make the patch smaller and open code the check does not look nice. -- Gleb.