Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 954 bytes --]

On Sunday 15 July 2012 15:54:51 Stefan Weil wrote:
> Am 15.07.2012 22:26, schrieb Mike Frysinger:
> > We should not quote the PKG_CONFIG setting as this deviates from the
> > canonical upstream behavior that gets integrated with all other build
> > systems, and deviates from how we treat all other toolchain variables
> > that we get from the environment.
> > 
> > Ultimately, the point is that it breaks passing custom flags directly
> > to pkg-config via the env var where this normally works elsewhere,
> > and it used to work in the past.
> 
> What about passing custom flags with QEMU_PKG_CONFIG_FLAGS?
> 
> Removing the quotes will not allow paths containing spaces,
> so that's not a good idea.

except that doesn't work with other build variables (like CC/etc...), nor does 
it work with the standard pkg-config build environments.  making qemu deviate 
from the standard to support non-existent setups makes no sense.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]