From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWl9-0005VK-5O for qemu-devel@nongnu.org; Sun, 15 Jul 2012 17:53:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqWl7-0002TP-TF for qemu-devel@nongnu.org; Sun, 15 Jul 2012 17:53:47 -0400 Received: from smtp.gentoo.org ([140.211.166.183]:36880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqWl7-0002T5-NO for qemu-devel@nongnu.org; Sun, 15 Jul 2012 17:53:45 -0400 From: Mike Frysinger Date: Sun, 15 Jul 2012 17:53:42 -0400 References: <1342383972-11640-1-git-send-email-vapier@gentoo.org> <5003200B.4070400@weilnetz.de> In-Reply-To: <5003200B.4070400@weilnetz.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2259468.E3BRMhDMj1"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201207151753.43186.vapier@gentoo.org> Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org --nextPart2259468.E3BRMhDMj1 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: > Am 15.07.2012 22:26, schrieb Mike Frysinger: > > We should not quote the PKG_CONFIG setting as this deviates from the > > canonical upstream behavior that gets integrated with all other build > > systems, and deviates from how we treat all other toolchain variables > > that we get from the environment. > >=20 > > Ultimately, the point is that it breaks passing custom flags directly > > to pkg-config via the env var where this normally works elsewhere, > > and it used to work in the past. >=20 > What about passing custom flags with QEMU_PKG_CONFIG_FLAGS? >=20 > Removing the quotes will not allow paths containing spaces, > so that's not a good idea. except that doesn't work with other build variables (like CC/etc...), nor d= oes=20 it work with the standard pkg-config build environments. making qemu devia= te=20 from the standard to support non-existent setups makes no sense. =2Dmike --nextPart2259468.E3BRMhDMj1 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJQAzvnAAoJEEFjO5/oN/WB1A4P/RDmGmi7OVTgQH/wT0gUyfea +7edSRCs+7sKUvdTPvK0madrQGT3y/bzfSlM1Y4Pq+2ySPAjngT4eXMw7vnL1k3i TOa4m42+ldrL6oOg2c7quS2RJXW/bZ9eq9TVYqxJVIlV6vbRI5N/BK6zRLfWetEq 7no1a8zBIRh8LCK55xtLTVoXvi7pgaQh8JUZgsxSO1v5hObBM3YbjgaQTL4B7jAx +1dc3JlIOvyaCvjlAFJqHWdsB2DrztcQLsncE+EaXLpWA9zY0P5HX9gpJDlsCJ9G xwjlmhJArfRy7LSLQEck3TW3fffb1T4pak+O3ZuFltLozERZXPT/5/47b6LLF5f2 B1J1ht5DikTYHub0SBuGKgHj1tFA5m6BI818Zq6+VqxQBql2YcdMZt2uYhpPyAx0 k1PIWXz2uvKwZixuRmruUA7I+yGBpy0s4lmoe3UExo77SAEH4xfEuNYPE/i2bcRj R0H4SQahZLaUOYViHqkLiVmJh6DQ5v7bfl8XUdmvxFguMh5L82BL7cr+vwDidnir HIBOBqBjp+6VZohqkfbLjBy6TM0lwXz13rVz+BTq4pfaZvDPDsJ2qdgli5f/Zgr8 wURzzW6eSvOk8CgW2qa5tkikandoPzHcXYdp3sELFNkZfQ1LNwG64cNMiYG/qMhp 4PMMSzavStvpNDPE+ivE =QQFc -----END PGP SIGNATURE----- --nextPart2259468.E3BRMhDMj1--