From: Luiz Capitulino <lcapitulino@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 01/17] qapi: fix error propagation
Date: Mon, 16 Jul 2012 17:44:48 -0300 [thread overview]
Message-ID: <20120716174448.605127cd@doriath.home> (raw)
In-Reply-To: <50047A1E.8030304@redhat.com>
On Mon, 16 Jul 2012 22:31:26 +0200
Laszlo Ersek <lersek@redhat.com> wrote:
> On 07/16/12 19:12, Luiz Capitulino wrote:
> > On Fri, 13 Jul 2012 21:11:15 +0200
> > Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> >
> >> I think doing it for error_set was just for symmetry and to avoid
> >> introducing excessive complexity.
> >
> > We already check if the error is set in several places, and I don't think
> > it will add much complexity. I still think that an assert() is better.
>
> If that means that the generated traversal code takes responsibility to
> call any visitor callback with a fresh error receptacle, IOW I can go
> ahead and just use error_set() in OptsVisitor and any firing assert will
> be blamed on the generator: fine :)
If that means it's finding bugs then that's great. On the other hand, if it
shows only false positives and we end up having to re-work the code just to
avoid that, then I'd agree on not having an assert().
next prev parent reply other threads:[~2012-07-16 20:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 8:22 [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 01/17] qapi: fix error propagation Laszlo Ersek
2012-07-13 16:38 ` Luiz Capitulino
2012-07-13 17:30 ` Laszlo Ersek
2012-07-13 19:11 ` Paolo Bonzini
2012-07-13 20:11 ` Laszlo Ersek
2012-07-16 17:12 ` Luiz Capitulino
2012-07-16 20:31 ` Laszlo Ersek
2012-07-16 20:44 ` Luiz Capitulino [this message]
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 02/17] qapi: generate C types for fixed-width integers Laszlo Ersek
2012-06-13 10:48 ` Paolo Bonzini
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 03/17] qapi: introduce "size" type Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 04/17] expose QemuOpt and QemuOpts struct definitions to interested parties Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor Laszlo Ersek
2012-06-13 10:50 ` Paolo Bonzini
2012-06-13 14:03 ` Laszlo Ersek
2012-07-13 16:51 ` Luiz Capitulino
2012-07-13 22:48 ` Laszlo Ersek
2012-07-13 23:09 ` Laszlo Ersek
2012-07-16 17:30 ` Luiz Capitulino
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 06/17] qapi schema: remove trailing whitespace Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 07/17] qapi schema: add Netdev types Laszlo Ersek
2012-06-13 10:50 ` Paolo Bonzini
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 08/17] hw, net: "net_client_type" -> "NetClientOptionsKind" (qapi-generated) Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 09/17] convert net_client_init() to OptsVisitor Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 10/17] convert net_init_nic() to NetClientOptions Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 11/17] convert net_init_dump() " Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 12/17] convert net_init_slirp() " Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 13/17] convert net_init_socket() " Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 14/17] convert net_init_vde() " Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 15/17] convert net_init_tap() " Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 16/17] convert net_init_bridge() " Laszlo Ersek
2012-06-13 8:22 ` [Qemu-devel] [PATCH v2 17/17] remove unused QemuOpts parameter from net init functions Laszlo Ersek
2012-06-13 10:54 ` [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing Paolo Bonzini
2012-07-01 13:33 ` Paolo Bonzini
2012-07-02 13:17 ` Luiz Capitulino
2012-07-13 16:46 ` Luiz Capitulino
2012-07-13 19:28 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120716174448.605127cd@doriath.home \
--to=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).