From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrTug-0005vk-Er for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:03:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrTub-00012y-7o for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:03:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrTua-00012s-Vy for qemu-devel@nongnu.org; Wed, 18 Jul 2012 09:03:29 -0400 Date: Wed, 18 Jul 2012 10:03:58 -0300 From: Luiz Capitulino Message-ID: <20120718100358.17f55395@doriath.home> In-Reply-To: <87394p2sc5.fsf@blackfin.pond.sub.org> References: <1342452355-9341-1-git-send-email-peter.maydell@linaro.org> <50068DF9.4010408@suse.de> <87a9yx48r5.fsf@blackfin.pond.sub.org> <87394p2sc5.fsf@blackfin.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qerror: Add QERR_PROPERTY_SET_AFTER_REALIZE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , Anthony Liguori , patches@linaro.org, qemu-devel@nongnu.org, Paolo Bonzini , Andreas =?ISO-8859-1?B?RuRy?= =?ISO-8859-1?B?YmVy?= On Wed, 18 Jul 2012 13:59:06 +0200 Markus Armbruster wrote: > Peter Maydell writes: >=20 > > On 18 July 2012 12:19, Markus Armbruster wrote: > >> Peter Maydell writes: > >> > >>> n 18 July 2012 11:20, Andreas F=E4rber wrote: > >>>> Am 16.07.2012 17:25, schrieb Peter Maydell: > >>>>> Add a new QError QERR_PROPERTY_SET_AFTER_REALIZE for attempts > >>>>> to set a QOM or qdev property after the object/device has been > >>>>> realized. This allows a slightly more informative diagnostic > >>>>> than the previous "permission denied" message. > >>>>> > >>>>> Signed-off-by: Peter Maydell > >>>>> --- > >>>>> Changes since the v1 (which was sent way back in March...): > >>>>> * rebased on master now a pile of qdev/qom changesd have landed > >>>>> * fixed some overlong lines > >>>>> * avoid gcc '?:' extension > >>>>> * a couple of set_ functions in qdev-properties.c are new since v1 > >>>>> and needed their QERR_PERMISSION_DENIED checks changing > >>>> > >>>> This does not yet seem to take into account the discussion with libv= irt > >>>> and Anthony on what parameters to pass. The ID generalization was > >>>> nack'ed by Anthony and a QOM path was suggested as alternative. Could > >>>> you please look into that? > >>> > >>> I'm afraid I'm not really sure what you're referring to here -- > >>> do you have a link to a discussion? > >>> > >>> All I want is for errors printed to the user to be a bit more > >>> helpful; the whole qerror infrastructure seems to make it > >>> somewhere between difficult and impossible to do that :-( > >> > >> Yup. One of the reasons why I detest it. > >> > >> A recent thread on how to recover from this disaster: > >> http://lists.nongnu.org/archive/html/qemu-devel/2012-06/msg03469.html > > > > That's interesting but I'm not sure how it's relevant. We already > > have QERR_PROPERTY values just this new one, so I don't see why > > this is any worse than the ones we have. If we come up with some > > new scheme we can convert this with all the rest. And I don't > > really want to block "improve this error message" on getting > > agreement for some big redesign effort... >=20 > I'm not objecting to your patch (I didn't even review it), just pointing > out there's a glimmer of hope on the "emitting error messages fit for > humans is somewhere between difficult and impossible" front. Yeah, I plan to fix that soon.