From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrZWw-0005yO-1Z for qemu-devel@nongnu.org; Wed, 18 Jul 2012 15:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrZWv-0004fg-0E for qemu-devel@nongnu.org; Wed, 18 Jul 2012 15:03:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrZWu-0004fY-Op for qemu-devel@nongnu.org; Wed, 18 Jul 2012 15:03:24 -0400 Date: Wed, 18 Jul 2012 22:03:55 +0300 From: "Michael S. Tsirkin" Message-ID: <20120718190355.GD2498@redhat.com> References: <1342624074-24650-1-git-send-email-stefanha@linux.vnet.ibm.com> <1342624074-24650-13-git-send-email-stefanha@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1342624074-24650-13-git-send-email-stefanha@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC v9 12/27] virtio-blk: Add workaround for BUG_ON() dependency in virtio_ring.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Anthony Liguori , kvm@vger.kernel.org, qemu-devel@nongnu.org, Khoa Huynh , Paolo Bonzini , Asias He On Wed, Jul 18, 2012 at 04:07:39PM +0100, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > hw/dataplane/vring.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/dataplane/vring.h b/hw/dataplane/vring.h > index 3eab4b4..44ef4a9 100644 > --- a/hw/dataplane/vring.h > +++ b/hw/dataplane/vring.h > @@ -1,6 +1,11 @@ > #ifndef VRING_H > #define VRING_H > > +/* Some virtio_ring.h files use BUG_ON() */ It's a bug then. Do we really need to work around broken systems? If yes let's just ship our own headers ... > +#ifndef BUG_ON > +#define BUG_ON(x) > +#endif > + > #include > #include "qemu-common.h" > > -- > 1.7.10.4