From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SsW8I-0004aa-Gm
	for qemu-devel@nongnu.org; Sat, 21 Jul 2012 05:37:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SsW8H-0004zj-Em
	for qemu-devel@nongnu.org; Sat, 21 Jul 2012 05:37:54 -0400
Date: Sat, 21 Jul 2012 10:37:46 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20120721093746.GA13805@stefanha-thinkpad.localdomain>
References: <1342546459-21993-1-git-send-email-i.mitsyanko@samsung.com>
	<5005A904.5000006@samsung.com> <5005AFA5.6080101@weilnetz.de>
	<CAFEAcA9t5qDGvOBTL0eb+nRZGdiNBBwqd020Gz+80ovGm3t+hA@mail.gmail.com>
	<5005BBD7.1000905@weilnetz.de>
	<CAFEAcA9n7+UVp9W20x8zs71cPxZWBu8o1FQxVSwq8o6TdGZ0BQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA9n7+UVp9W20x8zs71cPxZWBu8o1FQxVSwq8o6TdGZ0BQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: fix ALSA
 configure test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>, qemu-trivial <qemu-trivial@nongnu.org>, Stefan Weil <sw@weilnetz.de>, QEMU Developers <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <anthony@codemonkey.ws>

On Tue, Jul 17, 2012 at 08:28:40PM +0100, Peter Maydell wrote:
> On 17 July 2012 20:24, Stefan Weil <sw@weilnetz.de> wrote:
> > The arguments why -Werror is a bad idea for some configure tests
> > are reasonable.
> >
> > Nevertheless the QEMU community was able to produce thousands of
> > lines of code which compile without a warning, so we should be able
> > to create warning and error free code for a handful of configure
> > tests.
> 
> The trouble is that the warnings and errors here don't cause the
> build to fail noisily; that's a big distinction IMHO.
> I suppose we could make compile_prog do something like:
>  * run the compile test
>  * if it fails => test failure as now
>  * if it succeeds (and we're doing a Werror build at all),
>    rerun the same test with -Werror
>  * if that fails, abort configure with an error message
> Then we would have the same "make the problem obvious" effect
> that plain -Werror provides for our main compilation.
> 
> > The 4 patches above are valid and can be applied with or without
> > -Werror, therefore qemu-trivial or whoever does not have to wait for
> > Peter's patch.
> 
> Yes, I agree we might as well fix these errors since we've now
> noticed them, regardless of whether or not we apply my patch
> (which I've just sent).

Build/configure fixes should go straight into qemu.git.

Stefan