From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34316)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1StHYx-0002Jp-S7
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 08:16:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1StHYw-0007py-Rq
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 08:16:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1StHYw-0007pn-IS
	for qemu-devel@nongnu.org; Mon, 23 Jul 2012 08:16:34 -0400
Date: Mon, 23 Jul 2012 15:16:30 +0300
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20120723121630.GA26120@redhat.com>
References: <1342803890-1795-1-git-send-email-ehabkost@redhat.com>
	<1342803890-1795-2-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1342803890-1795-2-git-send-email-ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS PATCH 1/2] acpi: report real I/O APIC ID
 (0) on MADT table (v2)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, Kevin O'Connor <kevin@koconnor.net>, seabios@seabios.org, qemu-devel@nongnu.org

On Fri, Jul 20, 2012 at 02:04:49PM -0300, Eduardo Habkost wrote:
> When resetting an I/O APIC, its ID is set to 0, and SeaBIOS doesn't
> change it, so report it correctly on the MADT table.
> 
> Some hardware may require the BIOS to initialize I/O APIC ID to an
> unique value, but SeaBIOS doesn't do that. This patch at least makes the
> MADT table reflect reality.
> 
> Changes v1 -> v2:
>  - Cosmetic: whitespace change (removed extra newline)
>  - New patch description
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  src/acpi.c   |    2 +-
>  src/config.h |    1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpi.c b/src/acpi.c
> index d39cbd9..da3bc57 100644
> --- a/src/acpi.c
> +++ b/src/acpi.c
> @@ -336,7 +336,7 @@ build_madt(void)
>      struct madt_io_apic *io_apic = (void*)apic;
>      io_apic->type = APIC_IO;
>      io_apic->length = sizeof(*io_apic);
> -    io_apic->io_apic_id = CountCPUs;
> +    io_apic->io_apic_id = BUILD_IOAPIC_ID;
>      io_apic->address = cpu_to_le32(BUILD_IOAPIC_ADDR);
>      io_apic->interrupt = cpu_to_le32(0);
>  
mptable also have ioapic_id.

> diff --git a/src/config.h b/src/config.h
> index 3a70867..0d4066d 100644
> --- a/src/config.h
> +++ b/src/config.h
> @@ -52,6 +52,7 @@
>  #define BUILD_PCIMEM64_END        0x10000000000ULL
>  
>  #define BUILD_IOAPIC_ADDR         0xfec00000
> +#define BUILD_IOAPIC_ID           0
>  #define BUILD_HPET_ADDRESS        0xfed00000
>  #define BUILD_APIC_ADDR           0xfee00000
>  
> -- 
> 1.7.10.4

--
			Gleb.