From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StVs7-0002rv-P2 for qemu-devel@nongnu.org; Mon, 23 Jul 2012 23:33:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1StVs6-0005vg-RO for qemu-devel@nongnu.org; Mon, 23 Jul 2012 23:33:19 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:41175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1StVs6-0005vK-7R for qemu-devel@nongnu.org; Mon, 23 Jul 2012 23:33:18 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jul 2012 09:03:14 +0530 Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6O3XBhG14614550 for ; Tue, 24 Jul 2012 09:03:11 +0530 Received: from d28av02.in.ibm.com (loopback [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6O3XB6u017079 for ; Tue, 24 Jul 2012 13:33:11 +1000 Date: Tue, 24 Jul 2012 09:04:36 +0530 From: Bharata B Rao Message-ID: <20120724033436.GS1046@in.ibm.com> References: <20120721082917.GC1046@in.ibm.com> <20120723085031.GN1046@in.ibm.com> <500D60F6.6020903@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <500D60F6.6020903@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 0/2] GlusterFS support in QEMU - v2 Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , Anand Avati , Vijay Bellur , Stefan Hajnoczi , Amar Tumballi , Markus Armbruster , qemu-devel@nongnu.org On Mon, Jul 23, 2012 at 08:34:30AM -0600, Eric Blake wrote: > On 07/23/2012 03:20 AM, Stefan Hajnoczi wrote: > >> > >> So without the capability to pass custom options to block drivers, am I forced > >> to keep extending the file= with more and more options ? > >> > >> file=gluster:transport:server:port:volname:image ? > >> > >> Looks ugly and not easy to make any particular option optional. If needed I can > >> support this from GlusterFS backend. > > > > Kevin, Markus: Any thoughts on passing options to block drivers? > > Encoding GlusterFS options into a "filename" string is pretty > > cumbersome. > > On 07/23/2012 03:28 AM, ronnie sahlberg wrote:> Why not use > > > > -drive file=gluster://server[:port]/volname/image > > At which point, options can fit into this URI scheme: > > -drive file=gluster://server:port/volname/image?option1=foo&option2=bar > > where anything after the ? of the URI can introduce whichever options > you need. The URI covered everything and left only transport as the option, which could be made part of the URI itself ? So looks like we have two options: gluster://server[:port]/[transport]/volname/image vs gluster:server:[port]:[transport]:volname:image Unless there is a strong preference on one over the other, I am inclined to go with the latter (colon based) approach and expect user to provide double colons (::) wherever any default value needs to be specified. Eg 1. gluster:localhost:::test:/a.img Eg 2. gluster:localhost:0:socket:test:/a.img Regards, Bharata.