Re: [Qemu-devel] [RFC PATCH 2/4] qapi: Convert loadvm

[Luiz Capitulino <lcapitulino@redhat.com>]

On Thu, 12 Jul 2012 11:56:28 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> > ---
> 
> > +++ b/qapi-schema.json
> > @@ -1889,4 +1889,26 @@
> >  #
> >  # Since: 1.2
> >  ##
> > -{ 'command': 'savevm', 'data': {'*name': 'str'} }
> > \ No newline at end of file
> > +{ 'command': 'savevm', 'data': {'*name': 'str'} }
> > +
> > +##
> > +# @loadvm:
> 
> Similar to my question in 1/4, should this be named 'load-vm'?

Yes.

> 
> > +#
> > +# Set the whole virtual machine to the snapshot identified by the tag
> > +# 'tag' or the unique snapshot ID 'id'.
> > +#
> > +# @name: tag or id of existing snapshot
> > +#
> > +# Returns: Nothing on success
> > +#          If no block device can accept snapshots, SnapshotNotAccepted
> > +#          If no snapshot is found, SnapshotNotFound
> > +#          If snapshot is only disk snapshot, SnapshotInvalid
> > +#          If there is a writable device not supporting snapshots,
> > +#            SnapshotNotSupported
> > +#          If snapshot activate failed, SnapshotActivateFailed
> > +#          If open a block device for vm state fail, SnapshotOpenFailed
> > +#          If an error occures while loading vm state, SnapshotLoadFailed
> 
> s/occures/occurs/
>