From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1StiWX-0006R1-PT
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 13:03:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1StiWQ-00036r-5F
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 13:03:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23281)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1StiWP-00036m-TS
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 13:03:46 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6OH3jEx022163
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 24 Jul 2012 13:03:45 -0400
Date: Tue, 24 Jul 2012 14:04:22 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120724140422.7f9305b6@doriath.home>
In-Reply-To: <4FFF0FCC.7090602@redhat.com>
References: <cover.1342092497.git.phrdina@redhat.com>
	<02b44c1f24c0cc403b28e85fbf45daa382716425.1342092497.git.phrdina@redhat.com>
	<4FFF0FCC.7090602@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 2/4] qapi: Convert loadvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Pavel Hrdina <phrdina@redhat.com>, qemu-devel@nongnu.org

On Thu, 12 Jul 2012 11:56:28 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> > ---
> 
> > +++ b/qapi-schema.json
> > @@ -1889,4 +1889,26 @@
> >  #
> >  # Since: 1.2
> >  ##
> > -{ 'command': 'savevm', 'data': {'*name': 'str'} }
> > \ No newline at end of file
> > +{ 'command': 'savevm', 'data': {'*name': 'str'} }
> > +
> > +##
> > +# @loadvm:
> 
> Similar to my question in 1/4, should this be named 'load-vm'?

Yes.

> 
> > +#
> > +# Set the whole virtual machine to the snapshot identified by the tag
> > +# 'tag' or the unique snapshot ID 'id'.
> > +#
> > +# @name: tag or id of existing snapshot
> > +#
> > +# Returns: Nothing on success
> > +#          If no block device can accept snapshots, SnapshotNotAccepted
> > +#          If no snapshot is found, SnapshotNotFound
> > +#          If snapshot is only disk snapshot, SnapshotInvalid
> > +#          If there is a writable device not supporting snapshots,
> > +#            SnapshotNotSupported
> > +#          If snapshot activate failed, SnapshotActivateFailed
> > +#          If open a block device for vm state fail, SnapshotOpenFailed
> > +#          If an error occures while loading vm state, SnapshotLoadFailed
> 
> s/occures/occurs/
>