From: Stefan Hajnoczi <stefanha@gmail.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: markmc@redhat.com, aliguori@us.ibm.com,
rmarwah@linux.vnet.ibm.com, qemu-devel@nongnu.org,
chouteau@adacore.com, pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] net: Add interface to bridge when SIOCBRADDIF isn't available
Date: Tue, 24 Jul 2012 17:03:00 +0100 [thread overview]
Message-ID: <20120724160300.GA19605@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1342099471-4993-1-git-send-email-coreyb@linux.vnet.ibm.com>
On Thu, Jul 12, 2012 at 09:24:31AM -0400, Corey Bryant wrote:
> The bridge helper uses the SIOCBRADDIF ioctl to add an inteface to
> a bridge. SIOCBRADDIF is not available on old Linux versions. This
> patch adds support to use the SIOCDEVPRIVATE ioctl with BRCTL_ADD_IF
> if SIOCBRADDIF is not available.
>
> Reported-by: Fabien Chouteau <chouteau@adacore.com>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
> qemu-bridge-helper.c | 24 +++++++++++++++++++++---
> 1 file changed, 21 insertions(+), 3 deletions(-)
Thanks, applied to the net tree:
https://github.com/stefanha/qemu/commits/net
(Not pushed yet but will be available there once the existing net pull
request is merged.)
Stefan
prev parent reply other threads:[~2012-07-24 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 13:24 [Qemu-devel] [PATCH] net: Add interface to bridge when SIOCBRADDIF isn't available Corey Bryant
2012-07-13 15:16 ` Fabien Chouteau
2012-07-24 11:20 ` Paolo Bonzini
2012-07-24 16:03 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724160300.GA19605@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=chouteau@adacore.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=markmc@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rmarwah@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).