From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47190)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SthZm-0000fh-52
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 12:03:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SthZf-0000FO-S3
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 12:03:10 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:61069)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SthZf-0000F2-Kh
	for qemu-devel@nongnu.org; Tue, 24 Jul 2012 12:03:03 -0400
Received: by bkcji1 with SMTP id ji1so5477725bkc.4
	for <qemu-devel@nongnu.org>; Tue, 24 Jul 2012 09:03:02 -0700 (PDT)
Date: Tue, 24 Jul 2012 17:03:00 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20120724160300.GA19605@stefanha-thinkpad.localdomain>
References: <1342099471-4993-1-git-send-email-coreyb@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1342099471-4993-1-git-send-email-coreyb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] net: Add interface to bridge when
 SIOCBRADDIF isn't available
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: markmc@redhat.com, aliguori@us.ibm.com, rmarwah@linux.vnet.ibm.com, qemu-devel@nongnu.org, chouteau@adacore.com, pbonzini@redhat.com, afaerber@suse.de

On Thu, Jul 12, 2012 at 09:24:31AM -0400, Corey Bryant wrote:
> The bridge helper uses the SIOCBRADDIF ioctl to add an inteface to
> a bridge.  SIOCBRADDIF is not available on old Linux versions.  This
> patch adds support to use the SIOCDEVPRIVATE ioctl with BRCTL_ADD_IF
> if SIOCBRADDIF is not available.
> 
> Reported-by: Fabien Chouteau <chouteau@adacore.com>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
>  qemu-bridge-helper.c |   24 +++++++++++++++++++++---
>  1 file changed, 21 insertions(+), 3 deletions(-)

Thanks, applied to the net tree:
https://github.com/stefanha/qemu/commits/net

(Not pushed yet but will be available there once the existing net pull
request is merged.)

Stefan