From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su0qz-0002NP-76 for qemu-devel@nongnu.org; Wed, 25 Jul 2012 08:38:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Su0qu-0003Yr-Ld for qemu-devel@nongnu.org; Wed, 25 Jul 2012 08:38:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Su0qu-0003Yl-Dl for qemu-devel@nongnu.org; Wed, 25 Jul 2012 08:38:08 -0400 Date: Wed, 25 Jul 2012 09:38:45 -0300 From: Luiz Capitulino Message-ID: <20120725093845.72ee7b46@doriath.home> In-Reply-To: <1533784489.1724392.1343195714693.JavaMail.root@redhat.com> References: <20120712120907.0d22c66b@doriath.home> <1533784489.1724392.1343195714693.JavaMail.root@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org On Wed, 25 Jul 2012 01:55:14 -0400 (EDT) Amos Kong wrote: >=20 >=20 > ----- Original Message ----- > > On Thu, 5 Jul 2012 20:48:44 +0800 > > Amos Kong wrote: > >=20 > > > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > > > variables/functions in monitor.c, so reserve qmp_sendkey() > > > to monitor.c > > >=20 > > > key_defs[] in console.h is the mapping of key name to keycode, > > > Keys' index in the enmu and key_defs[] is same. > > >=20 > > > 'send-key' of QMP doesn't support key in hexadecimal format. > > >=20 > > > Signed-off-by: Amos Kong > > > --- > > > console.h | 152 ++++++++++++++++++++++++++++++++++ > > > hmp-commands.hx | 2 +- > > > hmp.c | 64 +++++++++++++++ > > > hmp.h | 1 + > > > monitor.c | 239 > > > ++++++------------------------------------------------ > > > qapi-schema.json | 46 +++++++++++ > > > qmp-commands.hx | 28 +++++++ > > > 7 files changed, 317 insertions(+), 215 deletions(-) >=20 > ... >=20 > > > diff --git a/qapi-schema.json b/qapi-schema.json > > > index 3b6e346..08e51c6 100644 > > > --- a/qapi-schema.json > > > +++ b/qapi-schema.json > > > @@ -1862,3 +1862,49 @@ > > > # Since: 0.14.0 > > > ## > > > { 'command': 'netdev_del', 'data': {'id': 'str'} } > > > + > > > +## > > > +# @KeyCodes: > >=20 > > s/KeyCodes/KeyCode >=20 >=20 > 'KeyCode' is not an available variable name. >=20 > | ./qapi-types.h:471: error: conflicting types for =E2=80=98KeyCode=E2=80= =99 > | /usr/include/X11/X.h:108: note: previous declaration of =E2=80=98KeyCod= e=E2=80=99 was here >=20 > How about 'CodeOfKey'? QKeyCode, maybe? Can you please paste the full error message? >=20 > > > +# > > > +# An enumeration of key name. > > > +# > > > +# This is used by the send-key command. > > > +# > > > +# Since: 1.2 > > > +## > > > +{ 'enum': 'KeyCodes', > > > + 'data': [ 'shift', 'shift_r', 'alt', 'alt_r', 'altgr', > > > 'altgr_r', 'ctrl', > > > + 'ctrl_r', 'menu', 'esc', '1', '2', '3', '4', '5', '6', > > > '7', '8', > > > + '9', '0', 'minus', 'equal', 'backspace', 'tab', 'q', > > > 'w', 'e', > > > + 'r', 't', 'y', 'u', 'i', 'o', 'p', 'bracket_left', > > > 'bracket_right', > > > + 'ret', 'a', 's', 'd', 'f', 'g', 'h', 'j', 'k', 'l', > > > 'semicolon', > > > + 'apostrophe', 'grave_accent', 'backslash', 'z', 'x', > > > 'c', 'v', 'b', > > > + 'n', 'm', 'comma', 'dot', 'slash', 'asterisk', 'spc', > > > 'caps_lock', > > > + 'f1', 'f2', 'f3', 'f4', 'f5', 'f6', 'f7', 'f8', 'f9', > > > 'f10', > > > + 'num_lock', 'scroll_lock', 'kp_divide', 'kp_multiply', > > > + 'kp_subtract', 'kp_add', 'kp_enter', 'kp_decimal', > > > 'sysrq', 'kp_0', > > > + 'kp_1', 'kp_2', 'kp_3', 'kp_4', 'kp_5', 'kp_6', > > > 'kp_7', 'kp_8', > > > + 'kp_9', 'less', 'f11', 'f12', 'print', 'home', 'pgup', > > > 'pgdn', 'end', > > > + 'left', 'up', 'down', 'right', 'insert', 'delete', > > > 'stop', 'again', > > > + 'props', 'undo', 'front', 'copy', 'open', 'paste', > > > 'find', 'cut', > > > + 'lf', 'help', 'meta_l', 'meta_r', 'compose' ] } >=20