From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stzz3-0000gn-6S for qemu-devel@nongnu.org; Wed, 25 Jul 2012 07:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Stzz1-0004Qp-Sr for qemu-devel@nongnu.org; Wed, 25 Jul 2012 07:42:29 -0400 Received: from paradis.irqsave.net ([109.190.18.76]:50502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stzz1-0004Nm-KI for qemu-devel@nongnu.org; Wed, 25 Jul 2012 07:42:27 -0400 Date: Wed, 25 Jul 2012 13:42:18 +0200 From: =?iso-8859-1?Q?Beno=EEt?= Canet Message-ID: <20120725114217.GD12455@irqsave.net> References: <1343203902-10524-1-git-send-email-benoit@irqsave.net> <1343203902-10524-3-git-send-email-benoit@irqsave.net> <500FD101.1080200@redhat.com> <20120725111519.GB12455@irqsave.net> <500FD633.9000507@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <500FD633.9000507@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 2/3] block: Use bdrv_get_backing_file_ancestors_count() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: =?iso-8859-1?Q?Beno=EEt?= Canet , benoit.canet@gmail.com, stefanha@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com Le Wednesday 25 Jul 2012 =E0 13:19:15 (+0200), Kevin Wolf a =E9crit : > Am 25.07.2012 13:15, schrieb Beno=EEt Canet: > > Le Wednesday 25 Jul 2012 =E0 12:57:05 (+0200), Kevin Wolf a =E9crit : > >> Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com: > >>> From: Beno=EEt Canet > >>> > >>> Use the dedicated counting function in qmp_query_block in order to > >>> propagate the backing file count to HMP. > >>> > >>> Signed-off-by: Benoit Canet > >>> --- > >>> block.c | 2 ++ > >>> qapi-schema.json | 9 ++++++--- > >>> 2 files changed, 8 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/block.c b/block.c > >>> index 03e0860..4aa3ea9 100644 > >>> --- a/block.c > >>> +++ b/block.c > >>> @@ -2448,6 +2448,8 @@ BlockInfoList *qmp_query_block(Error **errp) > >>> if (bs->backing_file[0]) { > >>> info->value->inserted->has_backing_file =3D true; > >>> info->value->inserted->backing_file =3D g_strdup(b= s->backing_file); > >>> + info->value->inserted->backing_file_ancestors_coun= t =3D > >>> + bdrv_get_backing_file_ancestors_count(bs); > >>> } > >>> =20 > >>> if (bs->io_limits_enabled) { > >>> diff --git a/qapi-schema.json b/qapi-schema.json > >>> index a92adb1..eb72c16 100644 > >>> --- a/qapi-schema.json > >>> +++ b/qapi-schema.json > >>> @@ -398,6 +398,8 @@ > >>> # > >>> # @backing_file: #optional the name of the backing file (for copy-= on-write) > >>> # > >>> +# @backing_file_ancestors_count: #optional the count of ancestors = backing files (for copy-on-write) > >>> +# > >> > >> Why is it optional? Would it be omitted rather than set to 0 if ther= e > >> are no backing files? > >=20 > > I made it optional because backing_file=3Dsomething is optional. > > So It seemed coherent to make it also optional. > > However I'll change it if you confirm it should be changed. >=20 > The reason why the backing file naem is optional is because there is no > valid value to use when there is no backing file. But for the count, 0 > makes perfect sense. Should I also make is alway present in the HMP output ? Beno=EEt >=20 > Kevin >=20